Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #11458: az ad sp credential reset doesn't reset service principal credential, resets app credential #11466

Closed
wants to merge 10 commits into from

Conversation

mikeliddle
Copy link

Fixes for issue #11458

Changes the behavior of az ad sp credential to act on the service principal resource instead of the application resource.


This checklist is used to make sure that common guidelines for a pull request are followed.

  • The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).

  • I adhere to the Command Guidelines.

@mikeliddle mikeliddle requested a review from jiasli as a code owner December 3, 2019 18:37
@jiasli jiasli self-assigned this Dec 4, 2019
@jiasli
Copy link
Member

jiasli commented Dec 4, 2019

If we decide to seperate sp and app credential commands. This line in reset_application_credential doesn't seem to be valid anymore:

query_exp = "servicePrincipalNames/any(x:x eq \'{0}\') or displayName eq '{0}'".format(name)

We can simply replace it with _resolve_application.

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 24, 2020

ad sp

@jiasli
Copy link
Member

jiasli commented Dec 22, 2021

Tracked by #11458

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge Service Attention This issue is responsible by Azure service team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants