az sf cluster node-type add does not add a new node type #21697
Description
az feedbackauto-generates most of the information requested below, as of CLI version 2.0.62
Describe the bug
az cli for service fabric nodetype add is throwing error with "StorageAccountsOperations"
Below command was executed where the error description was observed. It is reproducable by running the below cli command
az sf cluster node-type add --capacity 2 --cluster-name clustername
--node-type workers --resource-group resourcegroupname
--vm-password password --vm-user-name vmusername
--durability-level Bronze `
--vm-sku 'vmsku'
Error:
The command failed with an unexpected error. Here is the traceback:
'StorageAccountsOperations' object has no attribute 'create'
Traceback (most recent call last):
File 'D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\knack/cli.py', line 231, in invoke
File 'D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py', line 658, in execute
File 'D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py', line 721, in _run_jobs_serially
File 'D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py', line 692, in _run_job
File 'D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/init.py', line 328, in call
File 'D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/core/commands/command_operation.py', line 121, in handler
File 'D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/servicefabric/custom.py', line 695, in add_cluster_node_type
File 'D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/servicefabric/custom.py', line 916, in _create_vmss
File 'D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/servicefabric/custom.py', line 880, in create_vhd
File 'D:\a\1\s\build_scripts\windows\artifacts\cli\Lib\site-packages\azure/cli/command_modules/servicefabric/custom.py', line 888, in create_storage_account
AttributeError: 'StorageAccountsOperations' object has no attribute 'create'
To Reproduce
On an existing service fabric cluster the below command can be executed to add a new node type
az sf cluster node-type add --capacity 2 --cluster-name clustername
--node-type workers --resource-group resourcegroupname
--vm-password password --vm-user-name vmusername
--durability-level Bronze `
--vm-sku 'vmsku'
Expected behavior
The expected behavior is to add new node type with defined new node type name to the existing cluster. In the process it creates a new vmss and adds it to the existing cluster. However the command does not execute complaining about the storage account creations.
Environment summary
The cli was used on a Windows 11 workstation.
The service fabric cluster(not managed cluster) was used for the test. The cluster already was configured with primary/seed nodes and was healthy. If we want to add a new node type as per the below documentation.
https://docs.microsoft.com/en-us/cli/azure/sf/cluster/node-type?view=azure-cli-latest
Additional Context
Az powershell worked fine for the use case. However there are 2 other issues which were observed and will be reported in appropriate section.