[Containerapp] az containerapp compose create: Fix TypeError when docker-compose file include env_file without environment#9498
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
Hi @Greedygre Release SuggestionsModule: containerapp
Notes
|
There was a problem hiding this comment.
Pull request overview
This PR fixes a TypeError that occurred when using az containerapp compose create with docker-compose files that include an env_file directive without an environment section. The fix is implemented by upgrading the pycomposefile dependency from version 0.0.29 to 0.0.34, which presumably handles this edge case correctly.
- Updated the
pycomposefiledependency version to fix the TypeError - Added changelog entry documenting the bug fix
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/containerapp/setup.py | Upgraded pycomposefile dependency from >=0.0.29 to >=0.0.34 to fix TypeError |
| src/containerapp/HISTORY.rst | Added changelog entry documenting the fix for env_file without environment scenario |
|
|
||
| # TODO: Add any additional SDK dependencies here | ||
| DEPENDENCIES = ['pycomposefile>=0.0.29', 'docker', 'kubernetes==24.2.0'] | ||
| DEPENDENCIES = ['pycomposefile>=0.0.34', 'docker', 'kubernetes==24.2.0'] |
There was a problem hiding this comment.
The dependency upgrade fixes a TypeError when docker-compose files include env_file without environment, but there appears to be no test coverage for this specific scenario. Consider adding a test case in test_containerapp_compose_environment.py that verifies compose create works correctly when a docker-compose file specifies env_file without an environment section.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
Same as https://github.com/Azure/azure-cli/pull/32601/files
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.