{AKS} Suppress enable ssh message when adding a new nodepool to the existed automatic cluster#9079
{AKS} Suppress enable ssh message when adding a new nodepool to the existed automatic cluster#9079xmzhao0822 wants to merge 8 commits intoAzure:mainfrom
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @xmzhao0822, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Pull Request Overview
Suppresses the annoying "enable SSH" message when adding a node pool to an existing automatic cluster and shows the appropriate preview warning instead.
- Modifies SSH access warning logic to distinguish between automatic and non-automatic clusters
- Updates the
aks nodepool addcommand to pass cluster information to the decorator - Adds test coverage for the new behavior when adding node pools to automatic clusters
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/aks-preview/azext_aks_preview/custom.py | Retrieves managed cluster information and passes it to the agentpool decorator |
| src/aks-preview/azext_aks_preview/agentpool_decorator.py | Updates SSH access setup to use cluster SKU information and show appropriate warnings |
| src/aks-preview/azext_aks_preview/tests/latest/test_agentpool_decorator.py | Adds test case for SSH access warning behavior with automatic cluster SKU |
src/aks-preview/azext_aks_preview/tests/latest/test_agentpool_decorator.py
Outdated
Show resolved
Hide resolved
|
Hi @xmzhao0822
|
|
Please fix CI issues |
When adding a new node pool to an existed automatic cluster, we don't want to see annoying message: "The new node pool will enable SSH access, recommended to use ...."
We want to see warning message: SSH access is in preview
Related command
az aks create -g xm-rg -n xmauto --sku automaticaz aks nodepool add -g xm-rg --cluster-name xmauto --name userpool1 --node-count 1General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.