container up - skip ACR build if the docker hub image name is specified#897
Merged
panchagnula merged 8 commits intoAzure:masterfrom Aug 12, 2019
Merged
container up - skip ACR build if the docker hub image name is specified#897panchagnula merged 8 commits intoAzure:masterfrom
panchagnula merged 8 commits intoAzure:masterfrom
Conversation
added 8 commits
July 23, 2019 14:32
|
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR: |
panchagnula
approved these changes
Aug 12, 2019
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where the ACR code upload and build step happens even if you specify an image to be pulled from DockerHub.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions: