Skip to content

container up - skip ACR build if the docker hub image name is specified#897

Merged
panchagnula merged 8 commits intoAzure:masterfrom
nking-1:master
Aug 12, 2019
Merged

container up - skip ACR build if the docker hub image name is specified#897
panchagnula merged 8 commits intoAzure:masterfrom
nking-1:master

Conversation

@nking-1
Copy link

@nking-1 nking-1 commented Aug 12, 2019


Fixes a bug where the ACR code upload and build step happens even if you specify an image to be pulled from DockerHub.

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/Nking92/azure-cli-extensions.git@master#subdirectory=src/$EXT&egg=$EXT"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants