Skip to content

[AKS] Add option Ubuntu2204 and Ubuntu2404 to --os-sku for az aks nodepool add and az aks nodepool update #8795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
May 29, 2025

Conversation

anujmaheshwari1
Copy link
Contributor

@anujmaheshwari1 anujmaheshwari1 commented May 27, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks nodepool add
az aks nodepool update

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@Copilot Copilot AI review requested due to automatic review settings May 27, 2025 21:12
Copy link

azure-client-tools-bot-prd bot commented May 27, 2025

❌Azure CLI Extensions Breaking Change Test
❌aks-preview
rule cmd_name rule_message suggest_message
1010 - ParaPropUpdate aks nodepool add cmd aks nodepool add update parameter spot_max_price: updated property default from nan to nan please change property default from nan to nan for parameter spot_max_price of cmd aks nodepool add
⚠️ 1010 - ParaPropUpdate aks create cmd aks create update parameter os_sku: updated property choices from ['AzureLinux', 'CBLMariner', 'Mariner', 'Ubuntu'] to ['AzureLinux', 'CBLMariner', 'Mariner', 'Ubuntu', 'Ubuntu2204', 'Ubuntu2404']
⚠️ 1010 - ParaPropUpdate aks nodepool add cmd aks nodepool add update parameter os_sku: updated property choices from ['AzureLinux', 'CBLMariner', 'Mariner', 'Ubuntu', 'Windows2019', 'Windows2022', 'WindowsAnnual'] to ['AzureLinux', 'CBLMariner', 'Mariner', 'Ubuntu', 'Ubuntu2204', 'Ubuntu2404', 'Windows2019', 'Windows2022', 'WindowsAnnual']
⚠️ 1010 - ParaPropUpdate aks nodepool update cmd aks nodepool update update parameter os_sku: updated property choices from ['AzureLinux', 'Ubuntu'] to ['AzureLinux', 'Ubuntu', 'Ubuntu2204', 'Ubuntu2404']

Copy link

Hi @anujmaheshwari1,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR expands the available OS SKU options for AKS nodepools by adding support for Ubuntu-based images.

  • Adds constants and updates parameter lists for Ubuntu2204 and Ubuntu2404.
  • Updates help documentation and HISTORY to reflect the new options.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py Added a test for Ubuntu2204 using the new --os-sku option.
src/aks-preview/azext_aks_preview/_params.py Updated parameter lists to include Ubuntu2204 and Ubuntu2404.
src/aks-preview/azext_aks_preview/_help.py Revised help text to list Ubuntu2204 and Ubuntu2404.
src/aks-preview/azext_aks_preview/_consts.py Defined new constants for Ubuntu2204 and Ubuntu2404.
src/aks-preview/HISTORY.rst Updated history with the new OS SKU option.
Comments suppressed due to low confidence (1)

src/aks-preview/azext_aks_preview/tests/latest/test_aks_commands.py:2716

  • Consider adding tests for Ubuntu2404 to ensure both new OS SKU options are adequately covered.
@AllowLargeResponse()

@@ -85,6 +85,8 @@ Pending
* [BREAKING CHANGE] Rename `--enable-addon-autoscaling` to `--enable-optimized-addon-scaling` to `az aks create` commands.
* [BREAKING CHANGE] Rename `--enable-addon-autoscaling` to `--enable-optimized-addon-scaling` and `--disable-addon-autoscaling` to `--disable-optimized-addon-scaling` to `az aks update` commands.

* Add option `Ubuntu2204` to `--os-sku` for `az aks nodepool add` and `az aks nodepool update`.
Copy link
Preview

Copilot AI May 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The HISTORY entry mentions only Ubuntu2204; please update it to include Ubuntu2404 as well, in line with the changes made in the parameters and help documentation.

Copilot uses AI. Check for mistakes.

@yonzhan
Copy link
Collaborator

yonzhan commented May 27, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link

github-actions bot commented May 27, 2025

@FumingZhang
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@FumingZhang
Copy link
Member

applied fix for failed test cases in PR #8798

@FumingZhang
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@FumingZhang
Copy link
Member

Please update recording file src/aks-preview/azext_aks_preview/tests/latest/recordings/test_aks_nodepool_add_with_ossku_ubuntu2204.yaml, the API version used by resource related operations should be updated to 2024-11-01.

@FumingZhang
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

…_aks_nodepool_add_with_ossku_ubuntu2204.yaml

Co-authored-by: FumingZhang <81607949+FumingZhang@users.noreply.github.com>
@FumingZhang
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@zhoxing-ms zhoxing-ms merged commit 6f30f35 into Azure:main May 29, 2025
24 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ aks-preview-18.0.0b5 ] : https://dev.azure.com/msazure/One/_build/results?buildId=125651844&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants