Skip to content

[DataFactory] Support Oracle V2 app model #8792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2025
Merged

Conversation

Jingshu918
Copy link
Contributor

@Jingshu918 Jingshu918 commented May 27, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

We only update the python sdk used by CLI. The new feature is app model changes.
https://learn.microsoft.com/en-us/azure/data-factory/connector-overview

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@Copilot Copilot AI review requested due to automatic review settings May 27, 2025 02:41
Copy link

azure-client-tools-bot-prd bot commented May 27, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @Jingshu918,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented May 27, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for new features in ADF 1.0.4 by introducing additional enums and updating version information.

  • Introduces new enums (e.g. AzurePostgreSqlWriteMethodEnum, GreenplumAuthenticationType, OracleAuthenticationType, ValueType) in the management client models.
  • Updates the init.py file to export the newly added enum classes.
  • Increments version numbers in both vendored SDK and manual version files and updates HISTORY.rst.
  • Removes explicit inheritance from object in serializer/deserializer classes within _serialization.py for a more modern Python style.

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/datafactory/azext_datafactory/vendored_sdks/datafactory/models/_data_factory_management_client_enums.py Adds new enum classes for supporting new features.
src/datafactory/azext_datafactory/vendored_sdks/datafactory/models/init.py Updates the exports to include new enum classes.
src/datafactory/azext_datafactory/vendored_sdks/datafactory/_version.py Updates version number from 9.1.0 to 9.2.0.
src/datafactory/azext_datafactory/vendored_sdks/datafactory/_serialization.py Removes explicit “object” inheritance in class definitions.
src/datafactory/azext_datafactory/manual/version.py Updates manual version from 1.0.3 to 1.0.4.
src/datafactory/HISTORY.rst Updates history to reflect the new changes in 1.0.4.

Copy link

@calvinhzy
Copy link
Member

Hi, can you add tests for these new features?

@Jingshu918
Copy link
Contributor Author

@calvinhzy Is it necessary we add tests?
We only update the python sdk used by CLI. The new feature is app model changes.
https://learn.microsoft.com/en-us/azure/data-factory/connector-overview

@calvinhzy calvinhzy changed the title [DataFactory]Support new features in ADF 1.0.4 [DataFactory] Support Oracle V2 app model May 29, 2025
@calvinhzy calvinhzy merged commit b5b28ed into Azure:main May 29, 2025
24 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ datafactory-1.0.4 ] : https://dev.azure.com/msazure/One/_build/results?buildId=125668068&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants