Add hack extension to streamline creation of resources commonly used when hacking #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
May 14, 2019 16:09
added 9 commits
July 30, 2019 14:46
…re-cli-extensions into geektrainer/hack
|
If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR: |
zikalino
approved these changes
Sep 5, 2019
zikalino
reviewed
Sep 5, 2019
| -------- | ||
|
|
||
| **--name -n** | ||
| Name of the application. This will be used to name the Resource Group, App Service Plan, App Service, database server and database. Name must contain only letters and numbers, and start with a letter. |
There was a problem hiding this comment.
I have one suggestion here, while resource group must be unique in a subscription, database name for instance must be globally unique, so probably when creating database it would be good to add random prefix.
but this is something that could be done later.
There was a problem hiding this comment.
Thanks for the suggestion! I'm going to update the code to have the user provide the first 10 characters as a base, and then i'll append 6 random (or something like that)
zikalino
reviewed
Sep 5, 2019
|
|
||
|
|
||
| def hack_up(cmd, name, runtime, database, ai=None): | ||
| location = 'westus' |
There was a problem hiding this comment.
we could have default location, but it would be nice to be able to change it. it may happen for some reason that particular resource is unavailable lin "westus" location.
ManuInNZ
pushed a commit
to ManuInNZ/azure-cli-extensions
that referenced
this pull request
Apr 11, 2020
…when hacking (Azure#873) * Fixed typo on name of SQL server * Kickoff of hack extension * Added support for creating a database * Added simple build script for testing * Create database, begin adding app service support * updated build for full test run * Added support for creating website and adding app settings * Working on adding MySQL support * Added MySQL support * Adding support for switches and runtimes * Adding readme files * STarting readme * Added metadata * Adding support for Cognitive Services keys' * Added support for cogsvcs * adding CosmosDB support * Adding support for CosmosDB * Added suppot for CosmosDB * Kickoff of hack extension * Added support for creating a database * Added simple build script for testing * Create database, begin adding app service support * updated build for full test run * Added support for creating website and adding app settings * Working on adding MySQL support * Added MySQL support * Adding support for switches and runtimes * Adding readme files * STarting readme * Added metadata * Adding support for Cognitive Services keys' * Added support for cogsvcs * adding CosmosDB support * Adding support for CosmosDB * Added suppot for CosmosDB * Added validator and converted params to lower * Added readme * Updated readme * Cleanup for linting * Linting issues * Removing personal testing rig * More linting * More linting * Added code owner * Added licenses * Fixed comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
az hackis designed to solve one of the largest gaps we see with students at hackathons, which is creating the various resources commonly used on Azure. Specifically, this extension creates an App Services website, a database of the user's choosing, and optionally a universal key for Cognitive Services.This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions: