Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Networkcloud v20240701 Stable api version - Azure cli extension changes #8311

Merged

Conversation

priyamshet
Copy link
Member

@priyamshet priyamshet commented Nov 22, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Corresponding AAZ PR https://github.com/Azure/aaz/pull/630/files#

Copy link

azure-client-tools-bot-prd bot commented Nov 22, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @priyamshet,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 22, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

github-actions bot commented Nov 22, 2024

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Nov 22, 2024
@priyamshet
Copy link
Member Author

This is the stable version of the API (20240701) and we are following the versioning based on the instructions here https://github.com/Azure/azure-cli/blob/release/doc/extensions/versioning_guidelines.md
Please let us know if there are any more updates needed.

@kairu-ms

Hi @priyamshet

⚠️ Release Requirements

Module: networkcloud

  • ⚠️ Please update VERSION to be 2.0.0b8 in src/networkcloud/setup.py
  • ⚠️ Set azext.isPreview to true in azext_metadata.json for networkcloud

Notes

@yonzhan yonzhan requested review from kairu-ms and jsntcy November 23, 2024 01:44
@yonzhan yonzhan added this to the Backlog milestone Nov 23, 2024
@AllyW AllyW added the stable release extension module as stable label Nov 25, 2024
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Nov 25, 2024
@kairu-ms
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@priyamshet
Copy link
Member Author

@kairu-ms can we request the PR to be merged?

@kairu-ms kairu-ms merged commit 32a6330 into Azure:main Nov 26, 2024
25 of 26 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ networkcloud ] : https://dev.azure.com/azclitools/release/_build/results?buildId=109008840&view=results

ksayid pushed a commit to SethHollandsworth/azure-cli-extensions that referenced this pull request Jan 8, 2025
…es (Azure#8311)

Co-authored-by: priya shet <priyashet@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stable release extension module as stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants