Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AKS: Fix storage pool name validation for Azure Container Storage #8233

Merged
merged 5 commits into from
Nov 7, 2024

Conversation

mukhoakash
Copy link
Contributor

…name


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Nov 4, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @mukhoakash,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

Hi @mukhoakash,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 4, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Nov 4, 2024

Hi @mukhoakash

⚠️ Release Requirements

Module: aks-preview

  • ⚠️ Please update VERSION to be 11.1.0b1 in src/aks-preview/setup.py

Notes

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Queued live test to validate the change, test passed!

  • test_aks_create_with_azurecontainerstorage
  • test_aks_update_with_azurecontainerstorage
  • test_aks_create_with_azurecontainerstorage_with_ephemeral_disk_parameters
  • test_aks_update_with_azurecontainerstorage_with_ephemeral_disk_parameters
  • test_aks_create_with_azurecontainerstorage_with_nodepool_name

@yanzhudd
Copy link
Contributor

yanzhudd commented Nov 5, 2024

image

It is a known issue and has been fixed. Please rebase from the main branch to pick up the fix.

@yanzhudd yanzhudd added Docs and removed Docs labels Nov 6, 2024
@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Nov 7, 2024
@FumingZhang
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@FumingZhang
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@yanzhudd yanzhudd added minor release extension module with version minor upgraded skip-cal-version and removed minor release extension module with version minor upgraded labels Nov 7, 2024
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Nov 7, 2024
@yanzhudd yanzhudd merged commit 7464d03 into Azure:main Nov 7, 2024
33 of 37 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Nov 7, 2024

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=204174&view=results

chrisribe pushed a commit to chrisribe/azure-cli-extensions that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot minor release extension module with version minor upgraded skip-cal-version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants