Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] BREAKING CHANGE: az aks create: Remove legacy AAD related parameters when creating AKS cluster #8228

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

bingosummer
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az aks create --resource-group={resource_group} --name={name} \
  --aad-server-app-id 00000000-0000-0000-0000-000000000001 \
  --aad-server-app-secret fake-secret \
  --aad-client-app-id 00000000-0000-0000-0000-000000000002

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Nov 4, 2024

❌Azure CLI Extensions Breaking Change Test
❌aks-preview
rule cmd_name rule_message suggest_message
1007 - ParaRemove aks create cmd aks create removed parameter aad_client_app_id please add back parameter aad_client_app_id for cmd aks create
1007 - ParaRemove aks create cmd aks create removed parameter aad_server_app_id please add back parameter aad_server_app_id for cmd aks create
1007 - ParaRemove aks create cmd aks create removed parameter aad_server_app_secret please add back parameter aad_server_app_secret for cmd aks create

Copy link

Hi @bingosummer,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 4, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Nov 4, 2024

@bingosummer bingosummer changed the title [AKS] Remove legacy AAD related parameters [AKS] Remove legacy AAD related parameters when creating AKS cluster Nov 4, 2024
@karataliu
Copy link
Contributor

@bingosummer bingosummer force-pushed the aadv1 branch 2 times, most recently from 3d2c3a5 to c450247 Compare November 4, 2024 07:34
@bingosummer bingosummer requested a review from kairu-ms as a code owner November 4, 2024 07:34
@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Nov 4, 2024
@bingosummer bingosummer changed the title [AKS] Remove legacy AAD related parameters when creating AKS cluster [AKS] BREAKING CHANGE: az aks create: Remove legacy AAD related parameters when creating AKS cluster Nov 4, 2024
Copy link
Contributor

@karataliu karataliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yanzhudd yanzhudd removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Nov 5, 2024
@yanzhudd
Copy link
Contributor

yanzhudd commented Nov 5, 2024

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

… `--aad-client-app-id`, `--aad-server-app-id` and `--aad-server-app-secret` when creating cluster
@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Nov 5, 2024
@bingosummer
Copy link
Member Author

@yanzhudd I rebased and re-ran the test.

@yanzhudd yanzhudd added the major release extension module with version major upgraded label Nov 6, 2024
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Nov 6, 2024
@yanzhudd yanzhudd merged commit b990860 into Azure:main Nov 6, 2024
24 of 25 checks passed
@azclibot
Copy link
Collaborator

azclibot commented Nov 6, 2024

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=203878&view=results

chrisribe pushed a commit to chrisribe/azure-cli-extensions that referenced this pull request Nov 13, 2024
…`--aad-client-app-id`, `--aad-server-app-id` and `--aad-server-app-secret` when creating cluster (Azure#8228)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot major release extension module with version major upgraded
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants