Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[confcom] getting rid of msrestazure #8205

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

SethHollandsworth
Copy link
Contributor

There is a requirement to get rid of this dependency. It was not used, only imported so deleting the file will suffice.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az confcom

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Oct 28, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @SethHollandsworth,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 28, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

@evelyn-ys
Copy link
Member

/azp run

@wangzelin007
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@wangzelin007
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@evelyn-ys
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@evelyn-ys evelyn-ys merged commit 3311880 into Azure:main Oct 29, 2024
21 of 22 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ confcom ] : https://dev.azure.com/azclitools/release/_build/results?buildId=201701&view=results

@SethHollandsworth SethHollandsworth deleted the msrestazure branch October 29, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants