Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{virtual-network-tap} Migrate to AAZ Codegen #8203

Merged
merged 7 commits into from
Nov 11, 2024

Conversation

cxznmhdcxz
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Oct 28, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️virtual-network-tap
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd network nic vtap-config create cmd network nic vtap-config create added parameter no_wait
⚠️ 1008 - ParaPropAdd network nic vtap-config create cmd network nic vtap-config create update parameter network_interface_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd network nic vtap-config create cmd network nic vtap-config create update parameter network_interface_name: added property type=string
⚠️ 1009 - ParaPropRemove network nic vtap-config create cmd network nic vtap-config create update parameter network_interface_name: removed property id_part=name
⚠️ 1010 - ParaPropUpdate network nic vtap-config create cmd network nic vtap-config create update parameter network_interface_name: updated property name from network_interface_name to nic_name
⚠️ 1008 - ParaPropAdd network nic vtap-config create cmd network nic vtap-config create update parameter resource_group_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd network nic vtap-config create cmd network nic vtap-config create update parameter resource_group_name: added property type=string
⚠️ 1010 - ParaPropUpdate network nic vtap-config create cmd network nic vtap-config create update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1008 - ParaPropAdd network nic vtap-config create cmd network nic vtap-config create update parameter vnet_tap: added property aaz_type=string
⚠️ 1008 - ParaPropAdd network nic vtap-config create cmd network nic vtap-config create update parameter vnet_tap: added property type=string
⚠️ 1008 - ParaPropAdd network nic vtap-config create cmd network nic vtap-config create update parameter vtap_config_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd network nic vtap-config create cmd network nic vtap-config create update parameter vtap_config_name: added property type=string
⚠️ 1009 - ParaPropRemove network nic vtap-config create cmd network nic vtap-config create update parameter vtap_config_name: removed property id_part=child_name_1
⚠️ 1010 - ParaPropUpdate network nic vtap-config create cmd network nic vtap-config create update parameter vtap_config_name: updated property name from vtap_config_name to name
⚠️ 1006 - ParaAdd network nic vtap-config delete cmd network nic vtap-config delete added parameter no_wait
⚠️ 1006 - ParaAdd network nic vtap-config delete cmd network nic vtap-config delete added parameter yes
⚠️ 1008 - ParaPropAdd network nic vtap-config delete cmd network nic vtap-config delete update parameter network_interface_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd network nic vtap-config delete cmd network nic vtap-config delete update parameter network_interface_name: added property type=string
⚠️ 1010 - ParaPropUpdate network nic vtap-config delete cmd network nic vtap-config delete update parameter network_interface_name: updated property name from network_interface_name to nic_name
⚠️ 1008 - ParaPropAdd network nic vtap-config delete cmd network nic vtap-config delete update parameter resource_group_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd network nic vtap-config delete cmd network nic vtap-config delete update parameter resource_group_name: added property type=string
⚠️ 1010 - ParaPropUpdate network nic vtap-config delete cmd network nic vtap-config delete update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1008 - ParaPropAdd network nic vtap-config delete cmd network nic vtap-config delete update parameter tap_configuration_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd network nic vtap-config delete cmd network nic vtap-config delete update parameter tap_configuration_name: added property type=string
⚠️ 1010 - ParaPropUpdate network nic vtap-config delete cmd network nic vtap-config delete update parameter tap_configuration_name: updated property name from tap_configuration_name to name
⚠️ 1006 - ParaAdd network nic vtap-config list cmd network nic vtap-config list added parameter pagination_limit
⚠️ 1006 - ParaAdd network nic vtap-config list cmd network nic vtap-config list added parameter pagination_token
⚠️ 1008 - ParaPropAdd network nic vtap-config list cmd network nic vtap-config list update parameter network_interface_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd network nic vtap-config list cmd network nic vtap-config list update parameter network_interface_name: added property type=string
⚠️ 1010 - ParaPropUpdate network nic vtap-config list cmd network nic vtap-config list update parameter network_interface_name: updated property name from network_interface_name to nic_name
⚠️ 1008 - ParaPropAdd network nic vtap-config list cmd network nic vtap-config list update parameter resource_group_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd network nic vtap-config list cmd network nic vtap-config list update parameter resource_group_name: added property type=string
⚠️ 1010 - ParaPropUpdate network nic vtap-config list cmd network nic vtap-config list update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1008 - ParaPropAdd network nic vtap-config show cmd network nic vtap-config show update parameter network_interface_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd network nic vtap-config show cmd network nic vtap-config show update parameter network_interface_name: added property type=string
⚠️ 1010 - ParaPropUpdate network nic vtap-config show cmd network nic vtap-config show update parameter network_interface_name: updated property name from network_interface_name to nic_name
⚠️ 1008 - ParaPropAdd network nic vtap-config show cmd network nic vtap-config show update parameter resource_group_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd network nic vtap-config show cmd network nic vtap-config show update parameter resource_group_name: added property type=string
⚠️ 1010 - ParaPropUpdate network nic vtap-config show cmd network nic vtap-config show update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1008 - ParaPropAdd network nic vtap-config show cmd network nic vtap-config show update parameter tap_configuration_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd network nic vtap-config show cmd network nic vtap-config show update parameter tap_configuration_name: added property type=string
⚠️ 1010 - ParaPropUpdate network nic vtap-config show cmd network nic vtap-config show update parameter tap_configuration_name: updated property name from tap_configuration_name to name
⚠️ 1001 - CmdAdd network nic vtap-config wait cmd network nic vtap-config wait added
⚠️ 1006 - ParaAdd network vnet tap create cmd network vnet tap create added parameter no_wait
⚠️ 1008 - ParaPropAdd network vnet tap create cmd network vnet tap create update parameter destination: added property aaz_type=string
⚠️ 1008 - ParaPropAdd network vnet tap create cmd network vnet tap create update parameter destination: added property type=string
⚠️ 1008 - ParaPropAdd network vnet tap create cmd network vnet tap create update parameter location: added property aaz_type=string
⚠️ 1010 - ParaPropUpdate network vnet tap create cmd network vnet tap create update parameter location: updated property type from custom_type to string
⚠️ 1008 - ParaPropAdd network vnet tap create cmd network vnet tap create update parameter port: added property aaz_type=int
⚠️ 1008 - ParaPropAdd network vnet tap create cmd network vnet tap create update parameter port: added property type=int
⚠️ 1008 - ParaPropAdd network vnet tap create cmd network vnet tap create update parameter resource_group_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd network vnet tap create cmd network vnet tap create update parameter resource_group_name: added property type=string
⚠️ 1010 - ParaPropUpdate network vnet tap create cmd network vnet tap create update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1008 - ParaPropAdd network vnet tap create cmd network vnet tap create update parameter tags: added property aaz_type=AAZDictArg
⚠️ 1008 - ParaPropAdd network vnet tap create cmd network vnet tap create update parameter tags: added property type=Dict<String,String>
⚠️ 1010 - ParaPropUpdate network vnet tap create cmd network vnet tap create update parameter tags: updated property nargs from * to +
⚠️ 1008 - ParaPropAdd network vnet tap create cmd network vnet tap create update parameter tap_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd network vnet tap create cmd network vnet tap create update parameter tap_name: added property type=string
⚠️ 1009 - ParaPropRemove network vnet tap create cmd network vnet tap create update parameter tap_name: removed property id_part=name
⚠️ 1010 - ParaPropUpdate network vnet tap create cmd network vnet tap create update parameter tap_name: updated property name from tap_name to name
⚠️ 1006 - ParaAdd network vnet tap delete cmd network vnet tap delete added parameter no_wait
⚠️ 1006 - ParaAdd network vnet tap delete cmd network vnet tap delete added parameter yes
⚠️ 1008 - ParaPropAdd network vnet tap delete cmd network vnet tap delete update parameter resource_group_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd network vnet tap delete cmd network vnet tap delete update parameter resource_group_name: added property type=string
⚠️ 1010 - ParaPropUpdate network vnet tap delete cmd network vnet tap delete update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1008 - ParaPropAdd network vnet tap delete cmd network vnet tap delete update parameter tap_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd network vnet tap delete cmd network vnet tap delete update parameter tap_name: added property type=string
⚠️ 1010 - ParaPropUpdate network vnet tap delete cmd network vnet tap delete update parameter tap_name: updated property name from tap_name to name
⚠️ 1006 - ParaAdd network vnet tap list cmd network vnet tap list added parameter pagination_limit
⚠️ 1006 - ParaAdd network vnet tap list cmd network vnet tap list added parameter pagination_token
⚠️ 1008 - ParaPropAdd network vnet tap list cmd network vnet tap list update parameter resource_group_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd network vnet tap list cmd network vnet tap list update parameter resource_group_name: added property type=string
⚠️ 1010 - ParaPropUpdate network vnet tap list cmd network vnet tap list update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1008 - ParaPropAdd network vnet tap show cmd network vnet tap show update parameter resource_group_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd network vnet tap show cmd network vnet tap show update parameter resource_group_name: added property type=string
⚠️ 1010 - ParaPropUpdate network vnet tap show cmd network vnet tap show update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1008 - ParaPropAdd network vnet tap show cmd network vnet tap show update parameter tap_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd network vnet tap show cmd network vnet tap show update parameter tap_name: added property type=string
⚠️ 1010 - ParaPropUpdate network vnet tap show cmd network vnet tap show update parameter tap_name: updated property name from tap_name to name
⚠️ 1006 - ParaAdd network vnet tap update cmd network vnet tap update added parameter no_wait
⚠️ 1006 - ParaAdd network vnet tap update cmd network vnet tap update added parameter tags
⚠️ 1008 - ParaPropAdd network vnet tap update cmd network vnet tap update update parameter properties_to_add: added property aaz_type=AAZGenericUpdateAddArg
⚠️ 1008 - ParaPropAdd network vnet tap update cmd network vnet tap update update parameter properties_to_remove: added property aaz_type=AAZGenericUpdateRemoveArg
⚠️ 1008 - ParaPropAdd network vnet tap update cmd network vnet tap update update parameter properties_to_set: added property aaz_type=AAZGenericUpdateSetArg
⚠️ 1008 - ParaPropAdd network vnet tap update cmd network vnet tap update update parameter resource_group_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd network vnet tap update cmd network vnet tap update update parameter resource_group_name: added property type=string
⚠️ 1010 - ParaPropUpdate network vnet tap update cmd network vnet tap update update parameter resource_group_name: updated property name from resource_group_name to resource_group
⚠️ 1008 - ParaPropAdd network vnet tap update cmd network vnet tap update update parameter tap_name: added property aaz_type=string
⚠️ 1008 - ParaPropAdd network vnet tap update cmd network vnet tap update update parameter tap_name: added property type=string
⚠️ 1010 - ParaPropUpdate network vnet tap update cmd network vnet tap update update parameter tap_name: updated property name from tap_name to name
⚠️ 1001 - CmdAdd network vnet tap wait cmd network vnet tap wait added

Copy link

Hi @cxznmhdcxz,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 28, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

github-actions bot commented Oct 28, 2024

@cxznmhdcxz
Copy link
Member Author

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@cxznmhdcxz cxznmhdcxz force-pushed the migrate-virtual-network-tap branch from ca7fb67 to f13f6bb Compare November 5, 2024 09:11
@kairu-ms kairu-ms removed their assignment Nov 7, 2024
@cxznmhdcxz cxznmhdcxz marked this pull request as ready for review November 11, 2024 03:25
@cxznmhdcxz
Copy link
Member Author

do we need confirmation for delete commands? it might be breaking change to vendor sdk version

@evelyn-ys
Copy link
Member

do we need confirmation for delete commands? it might be breaking change to vendor sdk version

Pls mention this change in release notes

@evelyn-ys evelyn-ys merged commit d12600c into Azure:main Nov 11, 2024
21 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ virtual-network-tap ] : https://dev.azure.com/azclitools/release/_build/results?buildId=205061&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants