Feature deidservice first release #8195
Conversation
…vice-first-release
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
|
Hi @chrisribe, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
| def create_valid_random_name(prefix, length): | ||
| """Generate a random name that matches the required pattern.""" | ||
| if len(prefix) > length: | ||
| raise ValueError('The length of the prefix must not be longer than random name length') | ||
|
|
||
| padding_size = length - len(prefix) | ||
| if padding_size < 4: | ||
| raise ValueError('The randomized part of the name is shorter than 4, which may not be able to offer enough randomness') | ||
|
|
||
| random_part = ''.join(random.choices(string.ascii_lowercase + string.digits, k=padding_size)) | ||
| return prefix + random_part |
There was a problem hiding this comment.
Please reference this doc for random name https://github.com/Azure/azure-cli/blob/dev/doc/authoring_tests.md#sample-6-random-name-and-name-mapping
There was a problem hiding this comment.
Fixed, thanks!
I got lost here trying to figure out what the error was (accepted name format of the service vs random name).
The VCR.py error "AssertionError: Can't overwrite existing cassette" threw me in a loop.
The authoring_tests.md page should be re-written a bit, I may take a stab at it.
setup.py and HISTORY.rst seem correct, unless default version |
First release of deidservice CLI commands, needs review.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az deidservice
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.