Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove connection-monitor-preview #8194

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

cxznmhdcxz
Copy link
Member

Remove connection-monitor-preview, the commands are covered in main azure-cli repo


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Oct 24, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @cxznmhdcxz,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 24, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

@cxznmhdcxz cxznmhdcxz marked this pull request as ready for review October 24, 2024 07:16
@necusjz
Copy link
Member

necusjz commented Oct 25, 2024

do we need to remove the content in https://github.com/Azure/azure-cli-extensions/blob/main/src/index.json and https://github.com/Azure/azure-cli-extensions/blob/main/.github/CODEOWNERS as well?

@kairu-ms kairu-ms assigned necusjz and unassigned kairu-ms Oct 25, 2024
@kairu-ms kairu-ms requested a review from necusjz October 25, 2024 05:32
@necusjz necusjz merged commit 7878723 into Azure:main Oct 28, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants