{Interactive} Compliant with Python 3.12 #8186
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @ReaNAiveD, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
github-actions
bot
added
the
release-version-block
github-actions
bot
removed
the
release-version-block
| @@ -73,7 +70,7 @@ def __init__(self, cli_config, style=None): | |||
| self.config.write(config_file) | |||
| else: | |||
| with open(os.path.join(self.config_dir, CONFIG_FILE_NAME), 'r') as config_file: | |||
| self.config.readfp(config_file) # pylint: disable=deprecated-method | |||
There was a problem hiding this comment.
readfp is deprecated since Python 3.2. I guess use it to support Python 2.7.
https://docs.python.org/3.11/library/configparser.html#configparser.ConfigParser.readfp
There was a problem hiding this comment.
readfpis deprecated since Python 3.2. I guess use it to support Python 2.7.https://docs.python.org/3.11/library/configparser.html#configparser.ConfigParser.readfp
I thought we no longer needed to support Python 2?
There was a problem hiding this comment.
Yes, it's been EOL for almost five years.
|
[Release] Update index.json for extension [ interactive ] : https://dev.azure.com/azclitools/release/_build/results?buildId=199771&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
close #8171
Related command
az interactiveGeneral Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.