-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[aks-preview] Fix bug related to updating DCR when non monitoring add enabled through az aks enable-addons #8169
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
Hi @ganga1980, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
@ganga1980 Please add some test cases for this change and fix these CI issues |
CI failed on test case |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Queued live test to validate the change.
- test_aks_enable_monitoring_with_aad_auth_msi
- test_aks_enable_monitoring_with_aad_auth_msi_with_syslog
- test_aks_addon_enable_monitoring_with_aad_auth_uai_with_syslog
Thanks, @FumingZhang for fixing test failure. |
Co-authored-by: Yan Zhu <105691024+yanzhudd@users.noreply.github.com>
please add some test cases for the bug to verify the changes. |
added test to cover. |
[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=199149&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
Fix will avoid updating existing data collection rules if non monitoring addon trying to enable through
az aks enable-addons
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.