Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aks-preview] Fix bug related to updating DCR when non monitoring add enabled through az aks enable-addons #8169

Merged
merged 19 commits into from
Oct 22, 2024

Conversation

ganga1980
Copy link
Contributor

@ganga1980 ganga1980 commented Oct 20, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

Fix will avoid updating existing data collection rules if non monitoring addon trying to enable through
az aks enable-addons

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Oct 20, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @ganga1980,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 20, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Oct 20, 2024

@ganga1980 ganga1980 changed the title [aks-preview] Fix bug related to aks monitoring addon [aks-preview] Fix bug related to updating DCR when non monitoring add enabled through az aks enable-addons Oct 21, 2024
@zhoxing-ms
Copy link
Contributor

@ganga1980 Please add some test cases for this change and fix these CI issues

@FumingZhang
Copy link
Member

CI failed on test case test_aks_create_and_update_with_http_proxy_config, fixing in #8170

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Queued live test to validate the change.

  • test_aks_enable_monitoring_with_aad_auth_msi
  • test_aks_enable_monitoring_with_aad_auth_msi_with_syslog
  • test_aks_addon_enable_monitoring_with_aad_auth_uai_with_syslog

@ganga1980
Copy link
Contributor Author

@ganga1980 Please add some test cases for this change and fix these CI issues

Thanks, @FumingZhang for fixing test failure.

Co-authored-by: Yan Zhu <105691024+yanzhudd@users.noreply.github.com>
@yanzhudd
Copy link
Contributor

please add some test cases for the bug to verify the changes.

@ganga1980
Copy link
Contributor Author

please add some test cases for the bug to verify the changes.

added test to cover.

@yanzhudd yanzhudd merged commit c377ea8 into Azure:main Oct 22, 2024
20 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=199149&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants