Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Quantum] Remove msrestazure dependency #8145

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

warren-jones
Copy link
Contributor

@warren-jones warren-jones commented Oct 15, 2024

Removed all msrestazure dependencies from the quantum CLI extension.

Changes in workspace.py:

  • Deleted the CloudError import from msrestazure.azure_exceptions
  • Deleted an orphaned function containing the only reference to CloudError

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

Copy link

azure-client-tools-bot-prd bot commented Oct 15, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @warren-jones,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 15, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

Hi @warren-jones

Release Suggestions

Module: quantum

  • Please log updates into to src/quantum/HISTORY.rst
  • Update VERSION to 1.0.0b4 in src/quantum/setup.py

Notes

@warren-jones warren-jones changed the title [Quantum] [Draft - Do not merge] Remove msrestazure dependency [Quantum] Remove msrestazure dependency Oct 15, 2024
@warren-jones warren-jones marked this pull request as ready for review October 15, 2024 23:01
@necusjz necusjz merged commit f4fd626 into Azure:main Oct 16, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot Quantum az quantum
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants