Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{vm-repair} Add code documentation and fix Unbound exceptions #8124

Merged
merged 20 commits into from
Nov 27, 2024

Conversation

Sandido
Copy link
Member

@Sandido Sandido commented Oct 10, 2024


This PR is an example of using AI to add documentation to code and Github Copilot to find bugs to fix.
This PR adds code documentation to the big custom.py file.
This also fixes an Unbound exception bug in the existing_rg and copy_disk_id variables.
Fixed a duplicate test name error.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Oct 10, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @Sandido,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 10, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

github-actions bot commented Oct 10, 2024

@Sandido Sandido marked this pull request as ready for review October 14, 2024 17:31
src/vm-repair/HISTORY.rst Outdated Show resolved Hide resolved
@Sandido Sandido marked this pull request as draft November 19, 2024 22:20
@Sandido Sandido marked this pull request as ready for review November 22, 2024 20:53
@Sandido Sandido changed the title Add code documentation and fix Unbound exceptions {vm-repair} Add code documentation and fix Unbound exceptions Nov 22, 2024
@Sandido
Copy link
Member Author

Sandido commented Nov 22, 2024

@yanzhudd , please re-review and merge if possible.

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Nov 22, 2024
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Nov 26, 2024
@yanzhudd
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@yanzhudd yanzhudd merged commit a065517 into Azure:main Nov 27, 2024
20 of 21 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ vm-repair ] : https://dev.azure.com/msazure/One/_build/results?buildId=109101394&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants