-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add TL toggle on vm repair create to allow nested virtualization on repair VMs #7991
Conversation
…cli-extensions into adsandor/tlvmflag
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
vm repair create | cmd vm repair create added parameter disable_trusted_launch |
Hi @Sandido, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
Hi @Sandido Release SuggestionsModule: vm-repair
Notes
|
Please fix CI issues |
The error is in the Extension Index calculation: Seems unrelated to my changes. @yonzhan , is there a setting in the CI check for maxDiff that needs to be set? |
@yanzhudd Could you please help take a look at this issue? |
Trusted Launch does not currently allow Nested Virtualization connection. This is useful for our customer support engineers so we want to ensure they can continue this practice when needed.
This PR adds a toggle to turn off Trusted Launch in the repair VM. This will only occur when the user provides a decryption key for the vm.
In the standard case, the repair VM will not be Trusted Launch by default.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.