-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Service Connector] az source connection create fabric-sql
: Support Fabric SQL as target with passwordless experience
#7940
base: main
Are you sure you want to change the base?
Conversation
Validation for Breaking Change Starting...
Thanks for your contribution! |
Hi @brycechen1849, |
Hi @brycechen1849, |
Service Connector |
|
Azure cli serviceconnector module change is in PR Azure/azure-cli#29822 Waiting for above PR merge and then this one, since the code depending on code change in |
src/serviceconnector-passwordless/azext_serviceconnector_passwordless/_credential_free.py
Outdated
Show resolved
Hide resolved
96f9fdb
to
601c569
Compare
601c569
to
b76e0e0
Compare
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
@@ -636,6 +644,109 @@ def get_create_query(self): | |||
return [delete_q, role_q, grant_q] | |||
|
|||
|
|||
class FabricSqlHandler(TargetHandler): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you put the FabricSqlHandler in a new file? It could cause conflict if we change the file at the same time.
logger.warning("Connecting to database...") | ||
self.create_aad_user_in_sql(connection_args, query_list) | ||
|
||
def create_aad_user_in_sql(self, connection_args, query_list): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can inherit the SqlHandler to reuse the create_aad_user_in_sql function if you don't need to change it.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
Create linker
Example: Create linker with user identity
Example: Create linker with system identity
Update linker
update linker with user identity
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.