Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove azure-cli-iot-ext and sap-hana from index.json #769

Merged
merged 1 commit into from
Jun 12, 2019

Conversation

limingu
Copy link
Member

@limingu limingu commented Jun 12, 2019


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

@limingu limingu requested a review from tjprescott as a code owner June 12, 2019 17:43
@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/limingu/azure-cli-extensions.git@iot#subdirectory=src/$EXT&egg=$EXT"

@limingu limingu merged commit 43ed33d into Azure:master Jun 12, 2019
limingu added a commit to limingu/azure-cli-extensions that referenced this pull request Jun 12, 2019
@tjprescott
Copy link
Member

Why are these being removed? The IoT extension contains all of their data plane commands.

limingu added a commit that referenced this pull request Jun 13, 2019
* Revert "Remove azure-cli-iot-ext and sap-hana from index.json (#769)"

This reverts commit 43ed33d.

* Remove sap-hana
@limingu limingu deleted the iot branch June 14, 2019 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants