Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS} BREAKING CHANGE: az aks create: Updates to option --enable-managed-identity #7590

Merged
merged 3 commits into from
May 10, 2024

Conversation

FumingZhang
Copy link
Member

@FumingZhang FumingZhang commented May 8, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

  • {AKS} BREAKING CHANGE: az aks create: Updates to option --enable-managed-identity, sync change from azure-cli #28906.
  • {AKS} Fix several recording files broken by dependency bump (compute #28847)
    • test_aks_check_network
    • test_aks_create_and_update_with_http_proxy_config

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented May 8, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️aks-preview
rule cmd_name rule_message suggest_message
⚠️ 1009 - ParaPropRemove aks create cmd aks create update parameter enable_managed_identity: removed property default=True

Copy link

Hi @FumingZhang,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented May 8, 2024

AKS

Copy link

@MoazzemHossain-bot MoazzemHossain-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contributions.

Copy link

@MoazzemHossain-bot MoazzemHossain-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls do as well

Copy link

@MoazzemHossain-bot MoazzemHossain-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls do as well.

@FumingZhang FumingZhang changed the title {AKS} Fix several recording files broken by dependency bump {AKS} BREAKING CHANGE: az aks create: Updates to option --enable-managed-identity May 8, 2024
Copy link

github-actions bot commented May 8, 2024

⚠️ Release Suggestions

Module: aks-preview

  • ⚠️ Please update VERSION to be 3.0.0b14 in src/aks-preview/setup.py

Notes

  • Stable/preview tag is inherited from last release. If needed, please add stable/preview label to modify it.
  • Major/minor/patch/pre increment of version number is calculated by pull request code changes automatically. If needed, please add major/minor/patch/pre label to adjust it.
  • For more info about extension versioning, please refer to Extension version schema

Copy link

@Moazzem-Hossain-pixel Moazzem-Hossain-pixel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls help to resolve

@yanzhudd yanzhudd merged commit 7b5d54b into Azure:main May 10, 2024
15 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ aks-preview ] : https://dev.azure.com/azclitools/release/_build/results?buildId=156941&view=results

Copy link

@MoazzemHossain-bot MoazzemHossain-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need support

@FumingZhang FumingZhang deleted the fuming/aks-fix-test-0508 branch May 11, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants