-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding support for CMK encryption settings #7585
Conversation
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
dataprotection backup-vault create | cmd dataprotection backup-vault create added parameter cmk_encryption_key_uri |
||
dataprotection backup-vault create | cmd dataprotection backup-vault create added parameter cmk_encryption_state |
||
dataprotection backup-vault create | cmd dataprotection backup-vault create added parameter cmk_identity_type |
||
dataprotection backup-vault create | cmd dataprotection backup-vault create added parameter cmk_infrastructure_encryption |
||
dataprotection backup-vault create | cmd dataprotection backup-vault create added parameter cmk_user_assigned_identity_id |
||
dataprotection backup-vault create | cmd dataprotection backup-vault create added parameter user_assigned_identities |
||
dataprotection backup-vault update | cmd dataprotection backup-vault update added parameter cmk_encryption_key_uri |
||
dataprotection backup-vault update | cmd dataprotection backup-vault update added parameter cmk_encryption_state |
||
dataprotection backup-vault update | cmd dataprotection backup-vault update added parameter cmk_identity_type |
||
dataprotection backup-vault update | cmd dataprotection backup-vault update added parameter cmk_user_assigned_identity_id |
||
dataprotection backup-vault update | cmd dataprotection backup-vault update added parameter user_assigned_identities |
Hi @Karmah24, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
For more info about extension versioning, please refer to Extension version schema |
Dear concern,
Thank you very much for your kind cooperation. I am sorry to say, I don't have experience in this regard as because unable to give proper support, would like to request your kind favor to resolve this issue, if possible!
With Regards,
Moazzem Hossain
…________________________________
From: github-actions[bot] ***@***.***>
Sent: 07 May 2024 3:51 PM
To: Azure/azure-cli-extensions ***@***.***>
Cc: Subscribed ***@***.***>
Subject: Re: [Azure/azure-cli-extensions] Adding support for CMK encryption settings (PR #7585)
|
src/dataprotection/azext_dataprotection/aaz/latest/dataprotection/backup_vault/_create.py
Outdated
Show resolved
Hide resolved
src/dataprotection/azext_dataprotection/tests/latest/test_dataprotection_backup_vault.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contributions
…identity-type" This reverts commit a22734f.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
[Release] Update index.json for extension [ dataprotection ] : https://dev.azure.com/azclitools/release/_build/results?buildId=157028&view=results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need support
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.