az containerapp up: Fix InvalidResourceType error when cloud is not AzureCloud
#7551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Azure CLI Extensions Breaking Change Test
|
azure-client-tools-bot-prd
bot
added this to the May 2024 (2024-05-21)❗ Breaking change release ❗ milestone
|
Hi @Greedygre, |
|
Hi @Greedygre, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
bot
requested review from
yonzhan,
wangzelin007,
yanzhudd,
zhoxing-ms,
jsntcy,
ruslany,
sanchitmehta,
ebencarek,
JennyLawrance,
howang-ms,
vinisoto,
chinadragon0515,
vturecek,
torosent,
pagariyaalok,
Juliehzl and
jijohn14
|
|
About Integration test failed, wait for pr: #7545 |
Greedygre
force-pushed
the
xinyu/fix_mooncake_and_Fairfac_for_up
branch
from
643e749 to
e313818
Compare
This comment was marked as resolved.
This comment was marked as resolved.
jijohn14
approved these changes
Apr 26, 2024
Greedygre
changed the title
az containerapp up: Fix InvalidResourceType error when cloud in AzureChinaCloud or AzureUSGovernmentaz containerapp up: Fix InvalidResourceType error when cloud not in AzureCloud
LaylaLiu-gmail
approved these changes
Apr 26, 2024
Juliehzl
reviewed
Apr 26, 2024
Juliehzl
reviewed
Apr 26, 2024
Greedygre
changed the title
az containerapp up: Fix InvalidResourceType error when cloud not in AzureCloudaz containerapp up: Fix InvalidResourceType error when cloud is not AzureCloud
Juliehzl
reviewed
Apr 26, 2024
Juliehzl
approved these changes
Apr 26, 2024
yanzhudd
approved these changes
Apr 28, 2024
blackchoey
pushed a commit
to blackchoey/azure-cli-extensions
that referenced
this pull request
Apr 29, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az cli fails because GET for "Connnected Environments" resource type fails
"Connnected Environments" resource type is not added to mooncake and fairfax
az containerapp connected-env
az containerapp up
Test with AzureCloud, we can see the
az containerapp connected-env, with AzureChinaCloud, it cannot be found.General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.