Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS} Fix recording file for case test_aks_approuting_enable_with_keyvault_secrets_provider_addon_and_keyvault_id #7369

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

FumingZhang
Copy link
Member

@FumingZhang FumingZhang commented Mar 11, 2024


This checklist is used to make sure that common guidelines for a pull request are followed.

{AKS} Fix recording file for case test_aks_approuting_enable_with_keyvault_secrets_provider_addon_and_keyvault_id.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Mar 11, 2024

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @FumingZhang,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 11, 2024

AKS

@FumingZhang FumingZhang marked this pull request as ready for review March 11, 2024 08:43
@FumingZhang FumingZhang changed the title {AKS} Test update {AKS} Fix recording file for case test_aks_approuting_enable_with_keyvault_secrets_provider_addon_and_keyvault_id Mar 11, 2024
@yanzhudd yanzhudd merged commit 8148529 into Azure:main Mar 12, 2024
15 checks passed
@FumingZhang FumingZhang deleted the fuming/test-0311 branch March 19, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants