-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NGINX.NGINXPLUS 1.0.0 #7247
NGINX.NGINXPLUS 1.0.0 #7247
Conversation
❌Azure CLI Extensions Breaking Change Test
|
Hi @george-ngugi, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
Hi @jsntcy |
Might be worth having a constant for the api-version to avoid magic strings or potential errors in the future |
src/nginx/azext_nginx/aaz/latest/nginx/deployment/certificate/_delete.py
Show resolved
Hide resolved
@george-ngugi could you please update the pr in aaz repo Azure/aaz#403, to manually trigger the pipeline? thanks. |
@necusjz done |
[Release] Update index.json for extension [ nginx ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=137402&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)===============
| Style Check |
===============
Extensions: nginx
Running pylint on extensions...
Pylint: PASSED
Running flake8 on extensions...
Flake8: PASSED
python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)Ran 9 tests in 0.068s
OK (skipped=2)
Version was <1.0.0 so I updated to 1.0.0
For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.