Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS} Fix azdev style issues for command & custom #7122

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

FumingZhang
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Dec 26, 2023

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

Copy link

Hi @FumingZhang,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Dec 26, 2023

AKS

@FumingZhang
Copy link
Member Author

FumingZhang commented Jan 2, 2024

Queued full live test (rerun some failed flaky tests) to validate the change.

Test passed!

@FumingZhang FumingZhang marked this pull request as ready for review January 4, 2024 05:13
@yanzhudd yanzhudd merged commit 29e3d4b into Azure:main Jan 4, 2024
15 checks passed
@FumingZhang FumingZhang deleted the fuming/aks-style-p3-1226 branch January 4, 2024 06:07
ddouglas-msft pushed a commit to ddouglas-msft/azure-cli-extensions that referenced this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants