-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SSH] Cast "certificate_validity" as an int before calling ListCredentials #7077
[SSH] Cast "certificate_validity" as an int before calling ListCredentials #7077
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
Hi @vthiebaut10, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
@vthiebaut10 Could you add some scenario tests for this case? |
@zhoxing-ms I added a test, but it is not working, and I need some help to make it work.
I believe that this is implicitly calling the I added this test:
But this doesn't work because of the syntax of how Is there a way that I can modify this test to be able to check that |
@vthiebaut10 Sorry, I don't have any prior experience with this issue, and I currently don't have enough time to delve into the details of Python mock test.
Please note that the answers from LLM are for reference only |
@zhoxing-ms I spent a good amount of time looking for a solution for this, but I didn't find it. Would it be ok to merge this PR without a test case? the change is very minimal and it's very unlikely it would break anything. If that is ok I will remove this test and add it once I find a way to test it. |
@vthiebaut10 Okay, if you have already verified its effectiveness through other ways, then you can skip adding tests for now to avoid blocking this PR. |
@zhoxing-ms Removed the test. Tested the change in our team's end-to-end test pipeline. If this is good enough, feel free to merge and release this fix. |
[Release] Update index.json for extension [ ssh ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=137326&view=results |
This has never been a problem before, but a customer suddenly started having issues because ListCredentials was being called with a float instead of an int.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally? (pip install wheel==0.30.0
required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.