Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eventgrid] Set the max CLI core version as 2.0.66 #707

Merged
merged 1 commit into from
May 28, 2019

Conversation

limingu
Copy link
Member

@limingu limingu commented May 28, 2019


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/limingu/azure-cli-extensions.git@eventgrid#subdirectory=src/$EXT&egg=$EXT"

@limingu limingu requested a review from ahamad-MS May 28, 2019 21:05
@ahamad-MS
Copy link
Contributor

LGTM. I sign off

@limingu limingu merged commit 8dfa61f into Azure:master May 28, 2019
@limingu limingu deleted the eventgrid branch May 28, 2019 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants