Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] Fix for az aks approuting update command #7038

Merged
merged 8 commits into from
Dec 18, 2023
Merged

[AKS] Fix for az aks approuting update command #7038

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fb8bb1a
added operation_group
bosesuneha Nov 28, 2023
59122af
added changelog
bosesuneha Nov 28, 2023
4435984
modified test
bosesuneha Dec 5, 2023
e9abb50
updated live test recording
bosesuneha Dec 5, 2023
80afcec
Merge branch 'main' into fix-aks-approuting-update-command
bosesuneha Dec 5, 2023
32c780b
updated live test file
bosesuneha Dec 5, 2023
94ec538
Merge branch 'main' into fix-aks-approuting-update-command
bosesuneha Dec 6, 2023
db9fd8d
marked test as live_only
bosesuneha Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/aks-preview/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ To release a new version, please select a new version number (usually plus 1 to

Pending
+++++++
* Fix for `az aks approuting update` command failing on granting keyvault permissions to managed identity.

0.5.172
+++++++
Expand Down
1 change: 1 addition & 0 deletions src/aks-preview/azext_aks_preview/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2864,6 +2864,7 @@ def _keyvault_update(
raise InvalidArgumentValueError("Please provide a valid keyvault ID")

if mc.ingress_profile and mc.ingress_profile.web_app_routing and mc.ingress_profile.web_app_routing.enabled:
cmd.command_kwargs['operation_group'] = 'vaults'
keyvault_params = parse_resource_id(keyvault_id)
keyvault_subscription = keyvault_params['subscription']
keyvault_name = keyvault_params['name']
Expand Down