Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] Fix for app routing CLI #6968

Merged
merged 17 commits into from
Nov 27, 2023
Merged

[AKS] Fix for app routing CLI #6968

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
54f3d16
fix for app routing cli
bosesuneha Nov 9, 2023
73e2fc5
fix for failing test
bosesuneha Nov 9, 2023
d6e2ab9
fixed lint error
bosesuneha Nov 9, 2023
d1481ab
feedback change
bosesuneha Nov 9, 2023
3df06ae
more feedback change
bosesuneha Nov 9, 2023
c9d4569
removed unnecessary code
bosesuneha Nov 9, 2023
978082b
fix
bosesuneha Nov 9, 2023
c8beeac
removed set_up_app_routing_profile reference
bosesuneha Nov 9, 2023
e388d7a
Merge branch 'main' of https://github.com/bosesuneha/azure-cli-extens…
bosesuneha Nov 17, 2023
67d337b
Merge branch 'fix-for-approuting-cli' of https://github.com/bosesuneh…
bosesuneha Nov 17, 2023
4a1dfb0
updated live test recordings
bosesuneha Nov 17, 2023
07e6c12
updated live test recordings
bosesuneha Nov 17, 2023
b6b8e60
Merge branch 'main'
bosesuneha Nov 21, 2023
d231913
added changelog
bosesuneha Nov 21, 2023
a485119
Merge branch 'main' of https://github.com/bosesuneha/azure-cli-extens…
bosesuneha Nov 27, 2023
f905544
release version change
bosesuneha Nov 27, 2023
ae6a9a4
removed redundant recording file
bosesuneha Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
removed set_up_app_routing_profile reference
  • Loading branch information
@bosesuneha
bosesuneha committed Nov 9, 2023
commit c8beeace921243c54c266dc47655fbbf2264a9de
10 changes: 5 additions & 5 deletions src/aks-preview/azext_aks_preview/tests/latest/test_managed_cluster_decorator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -899,7 +899,7 @@ def test_mc_get_enable_network_observability(self):
# fail on get_enable_network_observability mutual exclusive error
with self.assertRaises(MutuallyExclusiveArgumentError):
ctx_4.get_enable_network_observability()

# Flag set to False.
ctx_5 = AKSPreviewManagedClusterContext(
self.cmd,
Expand Down Expand Up @@ -4385,7 +4385,7 @@ def test_set_up_app_routing_profile(self):
)
mc_1 = self.models.ManagedCluster(location="test_location")
dec_1.context.attach_mc(mc_1)
dec_mc_1 = dec_1.set_up_app_routing_profile(mc_1)
dec_mc_1 = dec_1.set_up_ingress_web_app_routing(mc_1)
ground_truth_ingress_profile_1 = self.models.ManagedClusterIngressProfile(
web_app_routing=self.models.ManagedClusterIngressProfileWebAppRouting(
enabled=True,
Expand Down Expand Up @@ -7205,7 +7205,7 @@ def test_setup_supportPlan(self):
name="Base",
tier="Premium")
premiumCluster = self.models.ManagedCluster(
location="test_location",
location="test_location",
support_plan=None,
sku=premiumSKU,
)
Expand Down Expand Up @@ -7253,7 +7253,7 @@ def test_update_supportPlan(self):
name="Base",
tier="Premium")
ltsCluster = self.models.ManagedCluster(
location="test_location",
location="test_location",
sku=premiumSKU,
support_plan="AKSLongTermSupport",
)
Expand Down Expand Up @@ -7284,7 +7284,7 @@ def test_update_supportPlan(self):
self.assertEqual(nonLTSClusterCalculated, expectedNonLTSCluster)

normalCluster = self.models.ManagedCluster(
location="test_location",
location="test_location",
sku=self.models.ManagedClusterSKU(
name="Base",
tier="Standard"),
Expand Down