Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Eventgrid] az eventgrid: Add new command group namespace to support managing eventgrid namespace #6764

Merged
merged 7 commits into from
Oct 23, 2023

Conversation

Jing-song
Copy link
Contributor


AAZ model: Azure/aaz#310

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Sep 15, 2023

⚠️Azure CLI Extensions Breaking Change Test
⚠️eventgrid
rule cmd_name rule_message suggest_message
⚠️ 1011 - SubgroupAdd eventgrid namespace sub group eventgrid namespace added

@azure-client-tools-bot-prd
Copy link

Hi @Jing-song,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Sep 15, 2023

Eventgrid

Copy link

@a-hamad a-hamad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.. left few comments

src/service_name.json Outdated Show resolved Hide resolved
src/service_name.json Outdated Show resolved Hide resolved
@jsntcy jsntcy merged commit e22ae2d into Azure:main Oct 23, 2023
14 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ eventgrid ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=98832&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants