Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SCVMM] Public Preview refresh using New Resource Model #6708

Merged
merged 19 commits into from
Sep 21, 2023

Conversation

nascarsayan
Copy link
Contributor

@nascarsayan nascarsayan commented Aug 30, 2023

  • Using New Resource Model for all VM operations:
    • vm command : Create, Update, Delete, Show, VirtualMachineInstance and Perform Operations on VM Instance
    • vm guest-agent command : Enable, Show VMInstanceGuestAgent
    • vm extension command : Create, Update, Delete, Show, List MachineExtensions
  • If underlying machine is not present, it gets created during vm create
  • Added delete-from-host flag for vm delete
  • Deprecated VM List option as VM Instance is a child resource of Machines.
  • Updated tests and helps accordingly.

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 30, 2023

SCVMM

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Aug 30, 2023

⚠️Azure CLI Extensions Breaking Change Test
⚠️scvmm
rule cmd_name rule_message suggest_message
⚠️ 1009 - ParaPropRemove scvmm vm create cmd scvmm vm create update parameter location: removed property required=True
⚠️ 1006 - ParaAdd scvmm vm delete cmd scvmm vm delete added parameter delete_from_host
⚠️ 1006 - ParaAdd scvmm vm delete cmd scvmm vm delete added parameter delete_machine
⚠️ 1011 - SubgroupAdd scvmm vm extension sub group scvmm vm extension added
⚠️ 1011 - SubgroupAdd scvmm vm guest-agent sub group scvmm vm guest-agent added

@azure-client-tools-bot-prd
Copy link

Hi @nascarsayan,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@azure-client-tools-bot-prd
Copy link

Hi @nascarsayan,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@nascarsayan nascarsayan marked this pull request as ready for review September 15, 2023 06:26
@yanzhudd
Copy link
Contributor

If you want to release a new version of the extension, please change the version in setup.py file.

@nascarsayan
Copy link
Contributor Author

nascarsayan commented Sep 18, 2023

If you want to release a new version of the extension, please change the version in setup.py file.

@yanzhudd We don't want to release this to the customers yet, we'll do that when around the time of Public Preview refresh

Co-authored-by: Yan Zhu <105691024+yanzhudd@users.noreply.github.com>
@yanzhudd
Copy link
Contributor

Please add tests for new added and changed commands.

@nascarsayan
Copy link
Contributor Author

nascarsayan commented Sep 18, 2023

Please add tests for new added and changed commands.

@yanzhudd , the tests for the new commandlets (Guest Agent and HCRP Extensions) will be added in a subsequent PR, by a core team member from VMM.
The code changes for Guest Agent and VM Extensions added in this PR are exactly similar to the connectedvmware code, which is already released to the customers.
CC: @miniagarwal0910

src/scvmm/HISTORY.rst Outdated Show resolved Hide resolved
Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
@zhoxing-ms zhoxing-ms merged commit 1da219c into Azure:main Sep 21, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants