Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Connectedk8s - RBAC: Add "arc "mode in Guard for using OBO service and deprecate --app-id & --app-secret params #6675

Merged
merged 17 commits into from
Nov 30, 2023
Merged

Connectedk8s - RBAC: Add "arc "mode in Guard for using OBO service and deprecate --app-id & --app-secret params #6675

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
080eab1
OBO: arc mode in Guard
Aug 2, 2023
257e154
add release notes
Aug 3, 2023
c17b2d0
update comments
Aug 22, 2023
54eaa0f
update version
Aug 22, 2023
aba962c
update comments
Aug 22, 2023
a8dbe56
update comments
Aug 22, 2023
65ae830
update comments
Aug 23, 2023
fa445b9
rm artifacts
Aug 23, 2023
15700d6
test and cleanup
julienstroheker Nov 2, 2023
ec012c1
Merge pull request #1 from julienstroheker/juliens/obo
vineeth-thumma Nov 9, 2023
0cb4aaf
deprecate --app-id & --app-secret
Nov 10, 2023
c16a2dc
Merge branch 'main' into main
vineeth-thumma Nov 10, 2023
8ce0c49
Update setup.py
vineeth-thumma Nov 10, 2023
87f95b8
update version
Nov 10, 2023
947114a
address comments
Nov 13, 2023
5494e95
update help
Nov 13, 2023
c7aa81b
update comments
Nov 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update comments
  • Loading branch information
Vineeth Thumma committed Aug 22, 2023
commit a8dbe561a3499f564f38c61af687ea0d9288c91b
2 changes: 1 addition & 1 deletion src/connectedk8s/azext_connectedk8s/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1456,7 +1456,7 @@ def enable_features(cmd, client, resource_group_name, cluster_name, features, ku
if enable_azure_rbac:
cmd_helm_upgrade.extend(["--set", "systemDefaultValues.guard.enabled=true"])
# Setting the default authnMode mode as "arc" for guard. This mode used Arc RBAC 1P apps for authN/authZ.
vineeth-thumma marked this conversation as resolved.
Show resolved Hide resolved
# This needs
# This mode in guard uses PoP token bases auth.
cmd_helm_upgrade.extend(["--set", "systemDefaultValues.guard.authnMode=arc"])
vineeth-thumma marked this conversation as resolved.
Show resolved Hide resolved
logger.warning("Please use the latest kubelogin version which has support for generating PoP token(s) needed by guard running in 'arc' authN mode.")
vineeth-thumma marked this conversation as resolved.
Show resolved Hide resolved
cmd_helm_upgrade.extend(["--set", "systemDefaultValues.guard.skipAuthzCheck={}".format(azrbac_skip_authz_check)])
Expand Down