Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

containeraapp add tests for ACR look up credential #6618

Merged
merged 2 commits into from
Aug 9, 2023
Merged

containeraapp add tests for ACR look up credential #6618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d56fa87
add tests for acr look up credential
Greedygre Aug 9, 2023
560033f
fix tests
Greedygre Aug 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/containerapp/azext_containerapp/containerapp_job_decorator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,9 +143,15 @@ def get_argument_disable_warnings(self):
def get_argument_registry_pass(self):
return self.get_param("registry_pass")

def set_argument_registry_pass(self, registry_pass):
self.set_param("registry_pass", registry_pass)

def get_argument_registry_server(self):
return self.get_param("registry_server")

def set_argument_registry_user(self, registry_user):
self.set_param("registry_user", registry_user)

def get_argument_registry_user(self):
return self.get_param("registry_user")

Expand Down Expand Up @@ -309,6 +315,8 @@ def construct_payload(self):
# Infer credentials if not supplied and its azurecr
if (self.get_argument_registry_user() is None or self.get_argument_registry_pass() is None) and self.get_argument_registry_identity() is None:
registry_user, registry_pass = _infer_acr_credentials(self.cmd, self.get_argument_registry_server(), self.get_argument_disable_warnings())
self.set_argument_registry_user(registry_user)
self.set_argument_registry_pass(registry_pass)

if not self.get_argument_registry_identity():
registries_def["username"] = self.get_argument_registry_user()
Expand Down
Loading