-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vmware] Use the New Resource Model for VM operations #6578
[vmware] Use the New Resource Model for VM operations #6578
Conversation
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
connectedvmware vm create | cmd connectedvmware vm create update parameter location : removed property required |
||
connectedvmware vm delete | cmd connectedvmware vm delete added parameter delete_from_host |
||
connectedvmware vm delete | cmd connectedvmware vm delete added parameter delete_machine |
Hi @nascarsayan, |
Hi @nascarsayan, |
vmware |
8c7ec09
to
29825c4
Compare
…into dev/snaskar/nrm-pp-refresh
@nascarsayan Please resolve these CI issues |
@nascarsayan Please note some breaking changes had been introduced in this PR. Could we use the deprecation process instead of directly breaking customers without giving them any preparation time? For more details about breaking change process, please refer to this doc Implementing Breaking Changes in Azure CLI |
@zhoxing-ms , VMware extension is in preview and never released any stable version. Let us know. For the swagger APIs we reviewed with ARM breaking changes team and got the sign off as offering is in preview. |
@zhoxing-ms , current extension is in preview. We never released any stable version to the customers as the offering is currently preview and not GA'ed yet. We reviewed the same with ARM breaking changes team and got the sign off for the preview refresh. We are also communicating the changes to our preview customers on this change. Let us know if you have any suggestions. |
Have fixed the breaking changes, by deprecating the |
src/test-output.xml
Outdated
@@ -0,0 +1,3 @@ | |||
<test-run id="2" testcasecount="1" result="Passed" start-time="2023-08-07 14:31:05.568996" end-time="2023-08-07 14:31:10.467617" duration="4" total="1" passed="1" failed="0" inconclusive="0" skipped="0" asserts="0" clr-version="3.10.2 (main, Mar 15 2022, 16:57:02) [GCC 9.3.0]" engine-version="3.6.2"><command-line>/home/arcvmware/Code/github.com/azure/.venv/lib/python3.10/site-packages/pytest/__main__.py -x -v --forked -p no:warnings --log-level=WARN --junit-xml /home/arcvmware/.azdev/env_config/home/arcvmware/Code/github.com/azure/.venv/test_results.xml /home/arcvmware/Code/github.com/azure/azure-cli-extensions/src/connectedvmware/azext_connectedvmware/tests/latest -n auto</command-line><filter><test re="0">/home/arcvmware/Code/github.com/azure/azure-cli-extensions/src/connectedvmware/azext_connectedvmware/tests/latest</test></filter><test-suite id="azext_connectedvmware/tests/latest/test_connectedvmware_scenario.py" name="azext_connectedvmware/tests/latest/test_connectedvmware_scenario.py" fullname="azext_connectedvmware/tests/latest/test_connectedvmware_scenario.py" methodname="" classname="" runstate="Runnable" type="Assembly" testcasecount="1" result="Passed" label="" start-time="2023-08-07 14:31:10.449712" end-time="2023-08-07 14:31:10.467224" duration="0.017512" asserts="0" total="1" passed="1" failed="0" warnings="0" inconclusive="0" skipped="0"><properties><property name="python_version" value="3.10.2 (main, Mar 15 2022, 16:57:02) [GCC 9.3.0]" /></properties><test-case id="100" name="azext_connectedvmware/tests/latest/test_connectedvmware_scenario.py::ConnectedvmwareScenarioTest::test_connectedvmware" fullname="azext_connectedvmware/tests/latest/test_connectedvmware_scenario.py::ConnectedvmwareScenarioTest::test_connectedvmware" methodname="test_connectedvmware" classname="ConnectedvmwareScenarioTest" runstate="Runnable" seed="1" result="Passed" label="" start-time="2023-08-07 14:31:10.449712" end-time="2023-08-07 14:31:10.467224" duration="0.017512" asserts="0"><properties><property name="python-version" value="3.10.2 (main, Mar 15 2022, 16:57:02) [GCC 9.3.0]" /><property name="fspath" value="azext_connectedvmware/tests/latest/test_connectedvmware_scenario.py" /></properties><environment framework-version="3.6.2" clr-version="3.10.2 (main, Mar 15 2022, 16:57:02) [GCC 9.3.0]" os-version="5.17.5-76051705-generic" platform="Linux" cwd="/home/arcvmware/Code/github.com/azure/azure-cli-extensions/src" machine-name="x86_64" user="" user-domain="" culture="en_IN" uiculture="en_IN" os-architecture="64bit" /><failure><message><![CDATA[[gw0] linux -- Python 3.10.2 /home/arcvmware/Code/github.com/azure/.venv/bin/python]]></message><stack-trace><![CDATA[None]]></stack-trace></failure><reason><message><![CDATA[WARNING msrest.serialization:serialization.py:187 Readonly attribute name will be ignored in class <class 'azext_connectedvmware.vendored_sdks.hybridcompute.models._models_py3.MachineExtension'> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are there two test-output.xml
files and one is in the root directory of extension repo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These might have been committed by mistake. Maybe they got created when I ran azdev test from a different folder or because there were two azdev extension repo
during development. I have removed these files.
Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
…zure-cli-extensions into dev/snaskar/nrm-pp-refresh
…gger merged to public
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.