[vmware] Use the New Resource Model for VM operations #6578

nascarsayan · 2023-07-31T11:52:05Z

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

azure-client-tools-bot-prd · 2023-07-31T11:52:08Z

⚠️Azure CLI Extensions Breaking Change Test

⚠️connectedvmware

rule cmd_name rule_message suggest_message

⚠️ 1009 - ParaPropRemove connectedvmware vm create cmd connectedvmware vm create update parameter location: removed property required

⚠️ 1006 - ParaAdd connectedvmware vm delete cmd connectedvmware vm delete added parameter delete_from_host

⚠️ 1006 - ParaAdd connectedvmware vm delete cmd connectedvmware vm delete added parameter delete_machine

azure-client-tools-bot-prd · 2023-07-31T11:52:11Z

Hi @nascarsayan,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

azure-client-tools-bot-prd · 2023-07-31T11:52:14Z

Hi @nascarsayan,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

yonzhan · 2023-07-31T11:52:16Z

vmware

…into dev/snaskar/nrm-pp-refresh

src/connectedvmware/azext_connectedvmware/custom.py

zhoxing-ms · 2023-08-07T01:41:10Z

@nascarsayan Please resolve these CI issues

zhoxing-ms · 2023-08-07T01:46:49Z

❌Azure CLI Extensions Breaking Change Test
❌connectedvmware
rule cmd_name rule_message suggest_message
❌ 1007 - ParaRemove connectedvmware vm delete cmd connectedvmware vm delete removed parameter retain please add back parameter retain for cmd connectedvmware vm delete
❌ 1002 - CmdRemove connectedvmware vm list cmd connectedvmware vm list removed please confirm cmd connectedvmware vm list removed

@nascarsayan Please note some breaking changes had been introduced in this PR. Could we use the deprecation process instead of directly breaking customers without giving them any preparation time? For more details about breaking change process, please refer to this doc Implementing Breaking Changes in Azure CLI

subbartt · 2023-08-07T07:58:39Z

❌Azure CLI Extensions Breaking Change Test
❌connectedvmware
rule cmd_name rule_message suggest_message
❌ 1007 - ParaRemove connectedvmware vm delete cmd connectedvmware vm delete removed parameter retain please add back parameter retain for cmd connectedvmware vm delete
❌ 1002 - CmdRemove connectedvmware vm list cmd connectedvmware vm list removed please confirm cmd connectedvmware vm list removed

@nascarsayan Please note some breaking changes had been introduced in this PR. Could we use the deprecation process instead of directly breaking customers without giving them any preparation time? For more details about breaking change process, please refer to this doc Implementing Breaking Changes in Azure CLI

@zhoxing-ms , VMware extension is in preview and never released any stable version. Let us know. For the swagger APIs we reviewed with ARM breaking changes team and got the sign off as offering is in preview.

subbartt · 2023-08-07T08:04:39Z

❌Azure CLI Extensions Breaking Change Test
❌connectedvmware
rule cmd_name rule_message suggest_message
❌ 1007 - ParaRemove connectedvmware vm delete cmd connectedvmware vm delete removed parameter retain please add back parameter retain for cmd connectedvmware vm delete
❌ 1002 - CmdRemove connectedvmware vm list cmd connectedvmware vm list removed please confirm cmd connectedvmware vm list removed

@nascarsayan Please note some breaking changes had been introduced in this PR. Could we use the deprecation process instead of directly breaking customers without giving them any preparation time? For more details about breaking change process, please refer to this doc Implementing Breaking Changes in Azure CLI

@zhoxing-ms , current extension is in preview. We never released any stable version to the customers as the offering is currently preview and not GA'ed yet. We reviewed the same with ARM breaking changes team and got the sign off for the preview refresh. We are also communicating the changes to our preview customers on this change. Let us know if you have any suggestions.

nascarsayan · 2023-08-07T14:52:00Z

❌Azure CLI Extensions Breaking Change Test
❌connectedvmware
rule cmd_name rule_message suggest_message
❌ 1007 - ParaRemove connectedvmware vm delete cmd connectedvmware vm delete removed parameter retain please add back parameter retain for cmd connectedvmware vm delete
❌ 1002 - CmdRemove connectedvmware vm list cmd connectedvmware vm list removed please confirm cmd connectedvmware vm list removed

@nascarsayan Please note some breaking changes had been introduced in this PR. Could we use the deprecation process instead of directly breaking customers without giving them any preparation time? For more details about breaking change process, please refer to this doc Implementing Breaking Changes in Azure CLI

Have fixed the breaking changes, by deprecating the vm list command and retain parameter.

zhoxing-ms · 2023-08-08T01:47:37Z

src/test-output.xml

@@ -0,0 +1,3 @@
+<test-run id="2" testcasecount="1" result="Passed" start-time="2023-08-07 14:31:05.568996" end-time="2023-08-07 14:31:10.467617" duration="4" total="1" passed="1" failed="0" inconclusive="0" skipped="0" asserts="0" clr-version="3.10.2 (main, Mar 15 2022, 16:57:02) [GCC 9.3.0]" engine-version="3.6.2"><command-line>/home/arcvmware/Code/github.com/azure/.venv/lib/python3.10/site-packages/pytest/__main__.py -x -v --forked -p no:warnings --log-level=WARN --junit-xml /home/arcvmware/.azdev/env_config/home/arcvmware/Code/github.com/azure/.venv/test_results.xml /home/arcvmware/Code/github.com/azure/azure-cli-extensions/src/connectedvmware/azext_connectedvmware/tests/latest -n auto</command-line><filter><test re="0">/home/arcvmware/Code/github.com/azure/azure-cli-extensions/src/connectedvmware/azext_connectedvmware/tests/latest</test></filter><test-suite id="azext_connectedvmware/tests/latest/test_connectedvmware_scenario.py" name="azext_connectedvmware/tests/latest/test_connectedvmware_scenario.py" fullname="azext_connectedvmware/tests/latest/test_connectedvmware_scenario.py" methodname="" classname="" runstate="Runnable" type="Assembly" testcasecount="1" result="Passed" label="" start-time="2023-08-07 14:31:10.449712" end-time="2023-08-07 14:31:10.467224" duration="0.017512" asserts="0" total="1" passed="1" failed="0" warnings="0" inconclusive="0" skipped="0"><properties><property name="python_version" value="3.10.2 (main, Mar 15 2022, 16:57:02) [GCC 9.3.0]" /></properties><test-case id="100" name="azext_connectedvmware/tests/latest/test_connectedvmware_scenario.py::ConnectedvmwareScenarioTest::test_connectedvmware" fullname="azext_connectedvmware/tests/latest/test_connectedvmware_scenario.py::ConnectedvmwareScenarioTest::test_connectedvmware" methodname="test_connectedvmware" classname="ConnectedvmwareScenarioTest" runstate="Runnable" seed="1" result="Passed" label="" start-time="2023-08-07 14:31:10.449712" end-time="2023-08-07 14:31:10.467224" duration="0.017512" asserts="0"><properties><property name="python-version" value="3.10.2 (main, Mar 15 2022, 16:57:02) [GCC 9.3.0]" /><property name="fspath" value="azext_connectedvmware/tests/latest/test_connectedvmware_scenario.py" /></properties><environment framework-version="3.6.2" clr-version="3.10.2 (main, Mar 15 2022, 16:57:02) [GCC 9.3.0]" os-version="5.17.5-76051705-generic" platform="Linux" cwd="/home/arcvmware/Code/github.com/azure/azure-cli-extensions/src" machine-name="x86_64" user="" user-domain="" culture="en_IN" uiculture="en_IN" os-architecture="64bit" /><failure><message><![CDATA[[gw0] linux -- Python 3.10.2 /home/arcvmware/Code/github.com/azure/.venv/bin/python]]></message><stack-trace><![CDATA[None]]></stack-trace></failure><reason><message><![CDATA[WARNING  msrest.serialization:serialization.py:187 Readonly attribute name will be ignored in class &lt;class 'azext_connectedvmware.vendored_sdks.hybridcompute.models._models_py3.MachineExtension'&gt;


Why are there two test-output.xml files and one is in the root directory of extension repo?

These might have been committed by mistake. Maybe they got created when I ran azdev test from a different folder or because there were two azdev extension repo during development. I have removed these files.

src/connectedvmware/HISTORY.rst

Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>

…zure-cli-extensions into dev/snaskar/nrm-pp-refresh

…gger merged to public

src/connectedvmware/setup.py

azure-client-tools-bot-prd bot added this to the August 2023 (2023-09-05) milestone Jul 31, 2023

nascarsayan added 5 commits July 31, 2023 17:28

change folder

6c3b6ad

added hybridcompute, fixed lint issues

695a302

temp

109d81b

generate sdk for suppressed apis

cb8afda

made necessary changes, todo: verify full flow and modify tests

29825c4

nascarsayan force-pushed the dev/snaskar/nrm-pp-refresh branch from 8c7ec09 to 29825c4 Compare July 31, 2023 11:59

Merge branch 'main' of https://github.com/Azure/azure-cli-extensions …

46f8661

…into dev/snaskar/nrm-pp-refresh

yonzhan requested review from zhoxing-ms and yanzhudd July 31, 2023 13:37

yonzhan assigned zhoxing-ms Jul 31, 2023

nascarsayan added 7 commits July 31, 2023 22:31

lint fixes

64294a9

modified tests, fixed lints, but put after delete failing

0bede36

not deleting machine resource till service bug gets fixed

63f0be4

re-enable cluster and hosts as pr is merged

fa1fe1b

remove extra #

7428fce

tests ran successfully

42da06e

add init.py in vendored_sdks folder

53688cc

nascarsayan marked this pull request as ready for review August 2, 2023 16:34

subbartt reviewed Aug 3, 2023

View reviewed changes

src/connectedvmware/azext_connectedvmware/custom.py Outdated Show resolved Hide resolved

nascarsayan added 3 commits August 5, 2023 13:12

infer kind from vcenter resource

ceaad41

minor version upgrade

0fdeaaf

lint and style

f981d8a

nascarsayan added 2 commits August 7, 2023 20:00

Deprecating retain and list

3704c17

Adding back the help for vm list

d6f4aaf

zhoxing-ms reviewed Aug 8, 2023

View reviewed changes

src/connectedvmware/HISTORY.rst Outdated Show resolved Hide resolved

nascarsayan and others added 3 commits August 8, 2023 09:05

Update src/connectedvmware/HISTORY.rst

72bef6e

Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>

remove test-output xml files

ead6ad1

Merge branch 'dev/snaskar/nrm-pp-refresh' of github.com:nascarsayan/a…

50ad349

…zure-cli-extensions into dev/snaskar/nrm-pp-refresh

zhoxing-ms approved these changes Aug 8, 2023

View reviewed changes

nascarsayan added 2 commits August 8, 2023 09:20

fix type for list

6975ab6

dont update version in setup.py so as not to release till we have swa…

241c114

…gger merged to public

nascarsayan commented Aug 8, 2023

View reviewed changes

src/connectedvmware/setup.py Outdated Show resolved Hide resolved

zhoxing-ms approved these changes Aug 8, 2023

View reviewed changes

zhoxing-ms merged commit 6f266c3 into Azure:main Aug 8, 2023
14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[vmware] Use the New Resource Model for VM operations #6578

[vmware] Use the New Resource Model for VM operations #6578

nascarsayan commented Jul 31, 2023 •

edited

Loading

azure-client-tools-bot-prd bot commented Jul 31, 2023 •

edited

Loading

azure-client-tools-bot-prd bot commented Jul 31, 2023

azure-client-tools-bot-prd bot commented Jul 31, 2023

yonzhan commented Jul 31, 2023

zhoxing-ms commented Aug 7, 2023

zhoxing-ms commented Aug 7, 2023 •

edited

Loading

subbartt commented Aug 7, 2023

subbartt commented Aug 7, 2023

nascarsayan commented Aug 7, 2023

zhoxing-ms Aug 8, 2023

nascarsayan Aug 8, 2023

		@@ -0,0 +1,3 @@
		<test-run id="2" testcasecount="1" result="Passed" start-time="2023-08-07 14:31:05.568996" end-time="2023-08-07 14:31:10.467617" duration="4" total="1" passed="1" failed="0" inconclusive="0" skipped="0" asserts="0" clr-version="3.10.2 (main, Mar 15 2022, 16:57:02) [GCC 9.3.0]" engine-version="3.6.2"><command-line>/home/arcvmware/Code/github.com/azure/.venv/lib/python3.10/site-packages/pytest/__main__.py -x -v --forked -p no:warnings --log-level=WARN --junit-xml /home/arcvmware/.azdev/env_config/home/arcvmware/Code/github.com/azure/.venv/test_results.xml /home/arcvmware/Code/github.com/azure/azure-cli-extensions/src/connectedvmware/azext_connectedvmware/tests/latest -n auto</command-line><filter><test re="0">/home/arcvmware/Code/github.com/azure/azure-cli-extensions/src/connectedvmware/azext_connectedvmware/tests/latest</test></filter><test-suite id="azext_connectedvmware/tests/latest/test_connectedvmware_scenario.py" name="azext_connectedvmware/tests/latest/test_connectedvmware_scenario.py" fullname="azext_connectedvmware/tests/latest/test_connectedvmware_scenario.py" methodname="" classname="" runstate="Runnable" type="Assembly" testcasecount="1" result="Passed" label="" start-time="2023-08-07 14:31:10.449712" end-time="2023-08-07 14:31:10.467224" duration="0.017512" asserts="0" total="1" passed="1" failed="0" warnings="0" inconclusive="0" skipped="0"><properties><property name="python_version" value="3.10.2 (main, Mar 15 2022, 16:57:02) [GCC 9.3.0]" /></properties><test-case id="100" name="azext_connectedvmware/tests/latest/test_connectedvmware_scenario.py::ConnectedvmwareScenarioTest::test_connectedvmware" fullname="azext_connectedvmware/tests/latest/test_connectedvmware_scenario.py::ConnectedvmwareScenarioTest::test_connectedvmware" methodname="test_connectedvmware" classname="ConnectedvmwareScenarioTest" runstate="Runnable" seed="1" result="Passed" label="" start-time="2023-08-07 14:31:10.449712" end-time="2023-08-07 14:31:10.467224" duration="0.017512" asserts="0"><properties><property name="python-version" value="3.10.2 (main, Mar 15 2022, 16:57:02) [GCC 9.3.0]" /><property name="fspath" value="azext_connectedvmware/tests/latest/test_connectedvmware_scenario.py" /></properties><environment framework-version="3.6.2" clr-version="3.10.2 (main, Mar 15 2022, 16:57:02) [GCC 9.3.0]" os-version="5.17.5-76051705-generic" platform="Linux" cwd="/home/arcvmware/Code/github.com/azure/azure-cli-extensions/src" machine-name="x86_64" user="" user-domain="" culture="en_IN" uiculture="en_IN" os-architecture="64bit" /><failure><message><![CDATA[[gw0] linux -- Python 3.10.2 /home/arcvmware/Code/github.com/azure/.venv/bin/python]]></message><stack-trace><![CDATA[None]]></stack-trace></failure><reason><message><![CDATA[WARNING msrest.serialization:serialization.py:187 Readonly attribute name will be ignored in class <class 'azext_connectedvmware.vendored_sdks.hybridcompute.models._models_py3.MachineExtension'>

[vmware] Use the New Resource Model for VM operations #6578

[vmware] Use the New Resource Model for VM operations #6578

Conversation

nascarsayan commented Jul 31, 2023 • edited Loading

Related command

General Guidelines

About Extension Publish

azure-client-tools-bot-prd bot commented Jul 31, 2023 • edited Loading

azure-client-tools-bot-prd bot commented Jul 31, 2023

azure-client-tools-bot-prd bot commented Jul 31, 2023

yonzhan commented Jul 31, 2023

zhoxing-ms commented Aug 7, 2023

zhoxing-ms commented Aug 7, 2023 • edited Loading

subbartt commented Aug 7, 2023

subbartt commented Aug 7, 2023

nascarsayan commented Aug 7, 2023

zhoxing-ms Aug 8, 2023

Choose a reason for hiding this comment

nascarsayan Aug 8, 2023

Choose a reason for hiding this comment

nascarsayan commented Jul 31, 2023 •

edited

Loading

azure-client-tools-bot-prd bot commented Jul 31, 2023 •

edited

Loading

zhoxing-ms commented Aug 7, 2023 •

edited

Loading