Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

containerapp refactor managed env show/list/delete/create/update #6568

Merged
merged 7 commits into from
Aug 1, 2023

Conversation

Greedygre
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az containerapp env show/list/delete/create/update

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 27, 2023

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @Greedygre,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@azure-client-tools-bot-prd
Copy link

Hi @Greedygre,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 27, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@Greedygre
Copy link
Contributor Author

Will rerun all tests related with --live

@Greedygre
Copy link
Contributor Author

Hi @zhoxing-ms @wangzelin007
The test failed due to following error, could you help to handle it?

======================================================================
ERROR: test_ref_doc_db-up (main.IndexRefDocs)

Traceback (most recent call last):
File "/mnt/vss/_work/1/s/./scripts/ci/index_ref_doc.py", line 71, in test
raise e
File "/mnt/vss/_work/1/s/./scripts/ci/index_ref_doc.py", line 68, in test
check_call(script_args)
File "/opt/hostedtoolcache/Python/3.10.12/x64/lib/python3.10/subprocess.py", line 369, in check_call
raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/opt/hostedtoolcache/Python/3.10.12/x64/bin/python', '/mnt/vss/_work/1/s/scripts/refdoc/generate.py', '--extension-file', '/tmp/tmpxsznkbhq/db_up-0.2.7-py2.py3-none-any.whl', '--output-dir', '/tmp/tmp0179mina/db-up']' returned non-zero exit status 1.


@wangzelin007
Copy link
Member

Hi @zhoxing-ms @wangzelin007 The test failed due to following error, could you help to handle it?

======================================================================

ERROR: test_ref_doc_db-up (main.IndexRefDocs)
Traceback (most recent call last): File "/mnt/vss/_work/1/s/./scripts/ci/index_ref_doc.py", line 71, in test raise e File "/mnt/vss/_work/1/s/./scripts/ci/index_ref_doc.py", line 68, in test check_call(script_args) File "/opt/hostedtoolcache/Python/3.10.12/x64/lib/python3.10/subprocess.py", line 369, in check_call raise CalledProcessError(retcode, cmd) subprocess.CalledProcessError: Command '['/opt/hostedtoolcache/Python/3.10.12/x64/bin/python', '/mnt/vss/_work/1/s/scripts/refdoc/generate.py', '--extension-file', '/tmp/tmpxsznkbhq/db_up-0.2.7-py2.py3-none-any.whl', '--output-dir', '/tmp/tmp0179mina/db-up']' returned non-zero exit status 1.

This issue is casued by pymssql library used by the db-up extension, and I created an issue here to track it.

@Greedygre
Copy link
Contributor Author

Hi @zhoxing-ms
Could you please help to review and merge this PR, thanks a lot!

@Greedygre
Copy link
Contributor Author

Hi @Greedygre, Please write the description of changes which can be perceived by customers into HISTORY.rst. If you want to release a new extension version, please update the version in setup.py as well.

This pr's changes cannot be perceived by customers. So should not update the history.rst.

@zhoxing-ms zhoxing-ms merged commit 639e10f into Azure:main Aug 1, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot ContainerApp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants