-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ContainerApp] Fix #501: az containerapp create --allow-insecure: Add Flag to Allow Container App Insecure Ingress #6555
Conversation
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
containerapp create | cmd containerapp create added parameter allow_insecure |
Hi @Juancpani, |
Hi @Juancpani, |
ContainerApp |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a test? Not having a test might block you from getting merged. Or maybe just edit a current one since its a small change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this just for create, we aren't adding it to update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also update the src/containerapp/HISTORY.rst file with this change just for book keeping
update already has it, just create was missing it. |
@Juancpani I see the |
Just realized my mistake, custom.py has |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure you did this already, but you can setup a storage account and upload a build of your cli environment as a whl using
azdev extension publish containerapp --storage-account STORAGE_ACCOUNT --storage-container STORAGE_CONTAINER --storage-account-key STORAGE_KEY
then anyone can add that version of the cli with az extension add --upgrade --source LINKTOWHL
If you do that, leave a comment and then I can also help test out the changes that way. Might be easier for us to catch bugs thats way too that we miss from just reading the changes
@yonzhan this is ready to go! |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.