Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added client type to az datamigration tde-migration #6543

Merged
merged 3 commits into from
Jul 30, 2023

Conversation

smartura
Copy link
Contributor

Added an extra parameter clientType "CLI" to console app call to inform app that its being invoked from a Az CLI commandlet.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Jul 21, 2023

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @smartura,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jul 21, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@smartura
Copy link
Contributor Author

smartura commented Jul 26, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

Thank you @yonzhan, @evelyn-ys just updated the PR to include history and a new version number.

@evelyn-ys evelyn-ys merged commit 2a38966 into Azure:main Jul 30, 2023
14 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ datamigration ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=77454&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants