-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support CORS policy and mTLS for CLI #6420
Conversation
Hi @zhenqxuMSFT, |
Thank you for your contribution! We will review the pull request and get back to you soon. |
src/containerapp/azext_containerapp/tests/latest/test_containerapp_commands.py
Show resolved
Hide resolved
update history |
|
||
@AllowLargeResponse(8192) | ||
@ResourceGroupPreparer(location="northeurope") | ||
@live_only() # passes live but hits CannotOverwriteExistingCassetteException when run from recording |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I ask why do you need to mark this test as @live_only()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It hits CannotOverwriteExistingCassetteException when run from recording, just like all other existing tests in this file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, there are many situations that may cause this CannotOverwriteExistingCassetteException
error. Could you please tell me more specific reasons?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TBH I do not know the exact reason as well. Locally it can pass without live_only but it fails on azure pipeline. Let me comment it out and rerun to show you,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm, seems it's passing now...
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.