Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing azdev publish with AzureFirewall #607

Merged
merged 5 commits into from
Mar 28, 2019
Merged

Conversation

tjprescott
Copy link
Member

Some minor fixes to AzureFirewall to test the azdev build and azdev publish commands.


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run ./scripts/ci/test_static.sh locally? (pip install pylint flake8 required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

@tjprescott tjprescott added this to the Sprint 58 milestone Mar 27, 2019
@tjprescott tjprescott requested a review from limingu March 27, 2019 23:29
@azuresdkci
Copy link

If this PR is for a new extension or change to an existing extension, use the following to try out the changes in this PR:

docker run -it microsoft/azure-cli:latest
export EXT=<NAME>
pip install --upgrade --target ~/.azure/cliextensions/$EXT "git+https://github.com/Azure/azure-cli-extensions.git@AzureFirewallUpdate#subdirectory=src/$EXT&egg=$EXT"

@tjprescott tjprescott merged commit b56847f into master Mar 28, 2019
@tjprescott tjprescott deleted the AzureFirewallUpdate branch March 28, 2019 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants