-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Extension: acrquery- Supporting the Azure Container Registry Metadata Search feature #5947
Conversation
acr |
@estebanreyl @toddysm @johnsonshi please take a look, thanks! |
Could you add some unit tests? |
You might need add readme and history files. |
Integration tests are failing because of unauthorized access to tests against premade registry. Which subscription do these integration tests have access to and is it possible to add a preconfigured ACR to that subscription so that these tests can pass? @yonzhan @zhoxing-ms |
@zhoxing-ms, ARM endpoint has been updated; however, it seems to be failing on the api-version. How can that be modified? |
@CarolineNB The CI issues are caused by the bumping api-version of Resource RP from |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/acrquery/setup.py
Outdated
'Intended Audience :: System Administrators', | ||
'Programming Language :: Python', | ||
'Programming Language :: Python :: 3', | ||
'Programming Language :: Python :: 3.6', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please note that in fact, Python 3.6 is no longer supported in Azure CLI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@zhoxing-ms it has been removed!
[Release] Update index.json for extension [ acrquery ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=50594&view=results |
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az acr query
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.json
automatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json
.