Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Extension: acrquery- Supporting the Azure Container Registry Metadata Search feature #5947

Merged
merged 32 commits into from
Apr 26, 2023

Conversation

CarolineNB
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az acr query

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 7, 2023

acr

@CarolineNB
Copy link
Contributor Author

@estebanreyl @toddysm @johnsonshi please take a look, thanks!

@huanwu
Copy link

huanwu commented Mar 20, 2023

Could you add some unit tests?

@huanwu
Copy link

huanwu commented Mar 20, 2023

You might need add readme and history files.

src/acrquery/azext_acrquery/_help.py Outdated Show resolved Hide resolved
@yonzhan yonzhan requested a review from huanwu March 20, 2023 22:45
@CarolineNB
Copy link
Contributor Author

Integration tests are failing because of unauthorized access to tests against premade registry. Which subscription do these integration tests have access to and is it possible to add a preconfigured ACR to that subscription so that these tests can pass? @yonzhan @zhoxing-ms

@CarolineNB
Copy link
Contributor Author

CarolineNB commented Apr 18, 2023

@zhoxing-ms, ARM endpoint has been updated; however, it seems to be failing on the api-version. How can that be modified?

@zhoxing-ms
Copy link
Contributor

@CarolineNB The CI issues are caused by the bumping api-version of Resource RP from 2021-04-01 to 2022-09-01 in azure-cli-core (PR link), so you need to pull the latest code from the remote dev branch of Azure/azure-cli repo and then re-record these failed tests in live mode.

src/acrquery/azext_acrquery/query.py Outdated Show resolved Hide resolved
src/acrquery/azext_acrquery/query.py Show resolved Hide resolved
src/acrquery/azext_acrquery/_help.py Show resolved Hide resolved
src/acrquery/setup.py Outdated Show resolved Hide resolved
src/acrquery/setup.py Outdated Show resolved Hide resolved
src/acrquery/setup.py Outdated Show resolved Hide resolved
src/acrquery/azext_acrquery/_help.py Outdated Show resolved Hide resolved
src/acrquery/azext_acrquery/tests/latest/test_acr_query.py Outdated Show resolved Hide resolved
src/acrquery/azext_acrquery/tests/latest/test_acr_query.py Outdated Show resolved Hide resolved
src/acrquery/setup.py Outdated Show resolved Hide resolved
Copy link
Member

@jaysterp jaysterp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

'Intended Audience :: System Administrators',
'Programming Language :: Python',
'Programming Language :: Python :: 3',
'Programming Language :: Python :: 3.6',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note that in fact, Python 3.6 is no longer supported in Azure CLI

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhoxing-ms it has been removed!

@zhoxing-ms zhoxing-ms merged commit de134b1 into Azure:main Apr 26, 2023
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ acrquery ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=50594&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants