[storage-preview] Azcopy- release blob delete/upload/download commands #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new executables with app id refresh token fix add upload command
limingu
reviewed
Mar 21, 2019
| # with self.argument_context('storage azcopy blob sync') as c: | ||
| # c.argument('destination', options_list=['--destination', '-d'], | ||
| # validator=validate_azcopy_container_destination_url) | ||
| # c.argument('source', options_list=['--source', '-s']) |
There was a problem hiding this comment.
Why these are commented out? Not ready or not working?
There was a problem hiding this comment.
Because of: Azure/azure-storage-azcopy#255. When azcopy releases again, we can re-test and add the functionality if it is in a good state.
limingu
reviewed
Mar 21, 2019
|
|
||
| # def storage_blob_download_batch(cmd, client, source, destination): | ||
| # azcopy = _azcopy_blob_client(cmd, client) | ||
| # azcopy.copy(_add_url_sas(source, azcopy.creds.sas_token), destination, flags=['--recursive']) |
There was a problem hiding this comment.
These comments out are because they are not working as well?
alexeldeib
pushed a commit
to alexeldeib/azure-cli-extensions
that referenced
this pull request
Mar 26, 2019
Azure#587) * added azcopy and call * abstract azcopy from operating system * implemented basic upload batch for non oauth flow * initial oauth wiring new executables with app id refresh token fix add upload command * add run-command, and cleaned up upload and download code * finished logic for up/downloads and run-command * add 10.0.8 files * simplified upload/download and added delete * small fixes and testing * pylint * fixed test * flake8 * fix bug with python script * add examples for new commands
ShreyaAnand
pushed a commit
to ShreyaAnand/azure-cli-extensions
that referenced
this pull request
Dec 31, 2024
Migrate subscription to AAZ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
./scripts/ci/test_static.shlocally? (pip install pylint flake8required)python scripts/ci/test_index.py -qlocally?For new extensions: