{CI} Add check __init__.py file in all extensions #5620
Conversation
ghost
requested a review
from 
ghost
added
the
|
Add check for init.py file |
wangzelin007
force-pushed
the
test_check_init
branch
from
7b2e870 to
0438623
Compare
wangzelin007
force-pushed
the
test_check_init
branch
from
e0c6c01 to
0438623
Compare
|
I think an alternative solution is to use |
| if os.path.isdir(src_d_full): | ||
| for d in os.listdir(src_d_full): | ||
| if d.startswith('azext_'): | ||
| # root_dir: azure-cli-extensions\src\ext_name\azext_ext_name |
There was a problem hiding this comment.
Nice comment! It makes the code very easy to understand! 👍
This is a very good suggestion, it solves the problem fundamentally, but we need to modify the setup.py files of all extensions Test screenshot: What worries me the most are some of the effects it might have:
|
| """ Check if the vendored_sdks directory contains __init__.py in all extensions """ | ||
| ref = [] | ||
| # SRC_PATH: azure-cli-extensions\src | ||
| for src_d in os.listdir(SRC_PATH): |
There was a problem hiding this comment.
Is it better to only check the extension that the PR is working on?
There was a problem hiding this comment.
os.walk is very fast, it takes less than six seconds to check all the files, and the incremental check takes more time and effort.
Check if the vendored_sdks directory contains
__init__.pyin all extensions.Will exclude empty vendored_sdks dir, for example:
azure-cli-extensions\src\containerapp-preview\azext_containerapp_preview\vendored_sdksis a empty dir that didn't contain any files.Test screenshot:
