Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spring] Add 'language_framework' param for BYOC. #5363

Merged
merged 3 commits into from
Sep 22, 2022
Merged

[Spring] Add 'language_framework' param for BYOC. #5363

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
734baff
[Spring] Add 'language_framework' param for BYOC.
LGDoor Sep 18, 2022
45278c7
Update the test cases.
LGDoor Sep 18, 2022
648879c
update the history.md.
LGDoor Sep 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[Spring] Add 'language_framework' param for BYOC.
  • Loading branch information
@LGDoor
LGDoor committed Sep 21, 2022
commit 734baff8ce9db41a4c944394324e5bb3ad423b2e
3 changes: 2 additions & 1 deletion src/spring/azext_spring/_deployment_source_factory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ def format_source(self, version=None, **kwargs):

def _format_container(self, container_registry=None, container_image=None,
container_command=None, container_args=None,
registry_username=None, registry_password=None, **_):
registry_username=None, registry_password=None, language_framework=None, **_):
if all(x is None for x in [container_image,
container_command, container_args,
registry_username, registry_password]):
Expand All @@ -121,6 +121,7 @@ def _format_container(self, container_registry=None, container_image=None,
command=container_command,
args=container_args,
image_registry_credential=credential,
language_framework=language_framework
)


Expand Down
2 changes: 2 additions & 0 deletions src/spring/azext_spring/_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -425,6 +425,8 @@ def prepare_logs_argument(c):
'container_command', help='The command of the container image.', arg_group='Custom Container')
c.argument(
'container_args', help='The arguments of the container image.', arg_group='Custom Container')
c.argument(
'language_framework', help='Language framework of the container image uploaded. Supported values: "springboot", "".', arg_group='Custom Container')
c.argument(
'build_env', build_env_type)
c.argument(
Expand Down
4 changes: 4 additions & 0 deletions src/spring/azext_spring/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,6 +283,7 @@ def app_deploy(cmd, client, resource_group, service, name,
registry_password=None,
container_command=None,
container_args=None,
language_framework=None,
build_env=None,
builder=None,
build_cpu=None,
Expand Down Expand Up @@ -336,6 +337,7 @@ def app_deploy(cmd, client, resource_group, service, name,
'registry_password': registry_password,
'container_command': container_command,
'container_args': container_args,
'language_framework': language_framework,
'build_env': build_env,
'build_cpu': build_cpu,
'build_memory': build_memory,
Expand Down Expand Up @@ -388,6 +390,7 @@ def deployment_create(cmd, client, resource_group, service, app, name,
registry_password=None,
container_command=None,
container_args=None,
language_framework=None,
build_env=None,
builder=None,
# deployment.settings
Expand Down Expand Up @@ -441,6 +444,7 @@ def deployment_create(cmd, client, resource_group, service, app, name,
'registry_password': registry_password,
'container_command': container_command,
'container_args': container_args,
'language_framework': language_framework,
'cpu': cpu,
'memory': memory,
'instance_count': instance_count,
Expand Down