Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{CI} Auto merge release pull reqeust create by azclibot #4950

Closed
wants to merge 3 commits into from

Conversation

wangzelin007
Copy link
Member

@wangzelin007 wangzelin007 commented Jun 7, 2022


image
We need to merge the PR created by azclibot in time.
Otherwise the index.json from the new PR does not contain the contents of the old PR.
And we must create a PR to fix the index.json conflict problem.
Such as: #4940 #4779

This PR will auto merge the PR created by azclibot.
For old steps, we still modify in Azure CLI Extensions Release pipeline.
image
For new steps, we add scripts in scripts/release directory. (For easy tracking and reviewing.)

There is a new pipeline Azure CLI Extensions Release Test Auto Merge to test auto merge.
image
image

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost added Auto-Assign Auto assign by bot CI labels Jun 7, 2022
@ghost ghost requested review from yonzhan, jiasli and kairu-ms June 7, 2022 07:02
@ghost ghost assigned wangzelin007 Jun 7, 2022
@ghost ghost added this to the Jun 2022 (2022-07-05) milestone Jun 7, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Jun 7, 2022

CI

@wangzelin007 wangzelin007 marked this pull request as ready for review June 8, 2022 02:22
@wangzelin007 wangzelin007 requested review from zhoxing-ms and jsntcy June 8, 2022 02:23
Comment on lines +44 to +45
with open('/tmp/token.txt') as f:
token = f.readline().replace("\n", "")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not fetch token from keyvault?

Copy link
Member Author

@wangzelin007 wangzelin007 Jun 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In old steps, we can use environment variable Azure subscription in Azure CLI option.
So it is easy to use azure cli command.
And the token.txt is get from the az keyvault commmand in last step, and the transfer between the two steps can only use a temporary file.
We have used another temporary file upgrade_extensions.txt to identify if there are extensions that need to be upgraded.
image

But new step I use python script which not support environment variable.
And after the job finished (about 4 mins) this agent will be delete, so I think it is safe.
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we use Arguments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants