Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Spring-Cloud] [Do not merge] Switch to 2022-03-01-preview sdk for msi command groups #4597

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/spring-cloud/azext_spring_cloud/_client_factory.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@
from .vendored_sdks.appplatform.v2022_01_01_preview import (
AppPlatformManagementClient as AppPlatformManagementClient_20220101preview
)
from .vendored_sdks.appplatform.v2022_03_01_preview import (
AppPlatformManagementClient as AppPlatformManagementClient_20220301preview
)
from .vendored_sdks.appplatform.v2021_06_01_preview import (
AppPlatformManagementClient as AppPlatformManagementClient_20210601preview
)
Expand All @@ -19,6 +22,10 @@
)


def cf_spring_cloud_20220301preview(cli_ctx, *_):
return get_mgmt_service_client(cli_ctx, AppPlatformManagementClient_20220301preview)


def cf_spring_cloud_20220101preview(cli_ctx, *_):
return get_mgmt_service_client(cli_ctx, AppPlatformManagementClient_20220101preview)

Expand Down
7 changes: 4 additions & 3 deletions src/spring-cloud/azext_spring_cloud/commands.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
from azure.cli.core.commands import CliCommandType
from azext_spring_cloud._utils import handle_asc_exception

from ._client_factory import (cf_spring_cloud_20220101preview,
from ._client_factory import (cf_spring_cloud_20220301preview,
cf_spring_cloud_20220101preview,
cf_spring_cloud_20201101preview,
cf_config_servers)
from ._transformers import (transform_spring_cloud_table_output,
Expand All @@ -31,7 +32,7 @@ def load_command_table(self, _):

app_command = CliCommandType(
operations_tmpl='azext_spring_cloud.app#{}',
client_factory=cf_spring_cloud_20220101preview
client_factory=cf_spring_cloud_20220301preview
)

service_registry_cmd_group = CliCommandType(
Expand Down Expand Up @@ -139,7 +140,7 @@ def load_command_table(self, _):
g.custom_command('append-persistent-storage', 'app_append_persistent_storage')
g.custom_command('append-loaded-public-certificate', 'app_append_loaded_public_certificate')

with self.command_group('spring-cloud app identity', client_factory=cf_spring_cloud_20220101preview,
with self.command_group('spring-cloud app identity', client_factory=cf_spring_cloud_20220301preview,
exception_handler=handle_asc_exception) as g:
g.custom_command('assign', 'app_identity_assign')
g.custom_command('remove', 'app_identity_remove')
Expand Down

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Large diffs are not rendered by default.

Loading