Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CosmosDB]: az cosmosdb dts: Add cosmos db data transfer commands #4563

Merged
merged 16 commits into from
May 12, 2022

Conversation

niteshvijay1995
Copy link
Contributor

@niteshvijay1995 niteshvijay1995 commented Mar 23, 2022


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@yonzhan
Copy link
Collaborator

yonzhan commented Mar 23, 2022

cosmosdb

@calvinhzy
Copy link
Member

Please add some tests if possible.

@evelyn-ys
Copy link
Member

  1. Please add tests for newly added commands.
  2. Don't forget to update version in setup.py and History.rst

@niteshvijay1995 niteshvijay1995 changed the title Add DTS commands [CosmosDB]: az cosmosdb dts: Add cosmos db data transfer commands Mar 30, 2022
@niteshvijay1995
Copy link
Contributor Author

Added tests

Copy link
Member

@evelyn-ys evelyn-ys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general

@evelyn-ys evelyn-ys merged commit c8dedfa into Azure:main May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants