Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS} Update error handling when creating cluster #4283

Merged
merged 1 commit into from
Jan 6, 2022

Conversation

FumingZhang
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

  • Update error handling when creating cluster.
    • Catch both CloudError and HttpResponseError, which would be raised since we have adopted track 2 SDK.
  • Add unit test.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@yonzhan
Copy link
Collaborator

yonzhan commented Dec 31, 2021

AKS

@yonzhan yonzhan added this to the Jan 2022 (2022-02-01) milestone Dec 31, 2021
@FumingZhang FumingZhang marked this pull request as ready for review January 4, 2022 04:25
@zhoxing-ms zhoxing-ms merged commit 6ac7b05 into Azure:main Jan 6, 2022
@FumingZhang FumingZhang deleted the fuming/refine-1231 branch January 24, 2022 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants